Display our custom error pages instead of catching them all as a generic 404

[bess]

Currently, the application can experience an error and not raise an exception. This is going to make it hard for us to track problems.

Code that is capturing the errors:

pdc_describe/app/controllers/works_controller.rb

Lines 395 to 433 in 2b8e495

	def rescue_aasm_error
	yield
	rescue AASM::InvalidTransition => error
	message = error.message
	if @work.errors.count > 0
	message = @work.errors.to_a.join(", ")
	end
	message.chop! if message.last == "."
	Honeybadger.notify("Invalid #{@work.current_transition}: #{error.message} errors: #{message}")
	transition_error_message = "We apologize, the following errors were encountered: #{message}. Please contact the PDC Describe administrators for any assistance."
	@errors = [transition_error_message]
	if @work.persisted?
	redirect_to edit_work_url(id: @work.id), notice: transition_error_message, params:
	else
	new_params = {}
	new_params[:wizard] = wizard_mode? if wizard_mode?
	new_params[:migrate] = migrating? if migrating?
	@form_resource_decorator = FormResourceDecorator.new(@work, current_user)
	redirect_to new_work_url(params: new_params), notice: transition_error_message, params: new_params
	end
	rescue StandardError => generic_error
	if action_name == "create"
	if @work.persisted?
	Honeybadger.notify("Failed to create the new Dataset #{@work.id}: #{generic_error.message}")
	@form_resource_decorator = FormResourceDecorator.new(@work, current_user)
	redirect_to edit_work_url(id: @work.id), notice: "Failed to create the new Dataset #{@work.id}: #{generic_error.message}", params:
	else
	Honeybadger.notify("Failed to create a new Dataset #{@work.id}: #{generic_error.message}")
	new_params = {}
	new_params[:wizard] = wizard_mode? if wizard_mode?
	new_params[:migrate] = migrating? if migrating?
	@form_resource_decorator = FormResourceDecorator.new(@work, current_user)
	redirect_to new_work_url(params: new_params), notice: "Failed to create a new Dataset: #{generic_error.message}", params: new_params
	end
	else
	redirect_to root_url, notice: "We apologize, an error was encountered: #{generic_error.message}. Please contact the PDC Describe administrators."
	end
	end

How to disable error catching at the load balancer so our own error pages will be displayed: pulibrary/princeton_ansible#4258

Acceptance criteria

• When an error is encountered loading a page, honeybadger gets the notification
• If it is an actual 404, do not raise an exception
• For either a 404 or a 5xx, display a PDC Describe branded error page with a helpful message

[bess]

@jrgriffiniii I merged your PR and deployed it to staging, but we still aren't seeing the custom error pages. Don't we need to change something on the load balancer to make these show up? (There is a link in the ticket with some breadcrumbs.)

[jrgriffiniii]

I have just successfully provisioned staging, I am going to proceed with provisioning for prod outside of business hours.

[jrgriffiniii]

This should be deployed into the production environment for review.