From 890580bb11be76a74cfdde31c770c9e47b6975b8 Mon Sep 17 00:00:00 2001 From: Christina Chortaria Date: Wed, 25 Sep 2024 10:19:20 -0400 Subject: [PATCH 1/2] [#476] Update blacklight to 8.3.0 to resolve issue [#375]: Button tag needs role attribute Co-authored-by: Vivian Ha --- Gemfile | 2 +- Gemfile.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index 1443e24..a7d6228 100644 --- a/Gemfile +++ b/Gemfile @@ -19,7 +19,7 @@ gem 'jquery-rails' gem 'jbuilder', '~> 2.5' gem 'pg' -gem "blacklight", '~> 8.1.0' +gem "blacklight", '~> 8.3.0' gem "view_component", "~> 2.66" gem 'sshkit' diff --git a/Gemfile.lock b/Gemfile.lock index a7e5992..f696428 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -100,7 +100,7 @@ GEM bcrypt (3.1.20) bcrypt_pbkdf (1.1.0) bigdecimal (3.1.8) - blacklight (8.1.0) + blacklight (8.3.0) globalid i18n (>= 1.7.0) jbuilder (~> 2.7) @@ -463,7 +463,7 @@ PLATFORMS DEPENDENCIES bcrypt_pbkdf - blacklight (~> 8.1.0) + blacklight (~> 8.3.0) bootstrap (~> 4.6) byebug capistrano From cbf214bebd777c6fe8b68e9b69468313082686c6 Mon Sep 17 00:00:00 2001 From: Christina Chortaria Date: Wed, 25 Sep 2024 10:30:34 -0400 Subject: [PATCH 2/2] Update show_page_spec Co-authored-by: Vivian Ha --- spec/system/flash_messages_spec.rb | 2 +- spec/system/show_page_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/system/flash_messages_spec.rb b/spec/system/flash_messages_spec.rb index c4279af..65f87b1 100644 --- a/spec/system/flash_messages_spec.rb +++ b/spec/system/flash_messages_spec.rb @@ -12,7 +12,7 @@ click_link('Log Out') visit '/catalog' expect(page).to have_text('Signed out successfully.') - find('#main-flashes > div > div > button-tag > span').click + find('#main-flashes > div > div > button > span').click expect(page).to have_no_content('Signed out successfully.') end end diff --git a/spec/system/show_page_spec.rb b/spec/system/show_page_spec.rb index 5b1c916..de3d2ce 100644 --- a/spec/system/show_page_spec.rb +++ b/spec/system/show_page_spec.rb @@ -8,7 +8,7 @@ it 'has a bookmark checkbox' do visit '/catalog/resource3' - expect(page).to have_css('#bookmark_toggle_resource3', visible: :hidden) + expect(page).to have_css('input.toggle-bookmark') end it 'has no citation link' do