From 745df7d5715448ef5e47c527888e7e649955fd6e Mon Sep 17 00:00:00 2001 From: Mateusz Dahlke <39696234+Xavrax@users.noreply.github.com> Date: Fri, 13 Sep 2024 12:54:08 +0200 Subject: [PATCH] Release/v0.1.3 (#23) --- Config/FilterPlugin.ini | 8 -------- .../PubnubLibrary/Private/PubnubSubsystem.cpp | 20 +++++++------------ Source/PubnubLibrary/Public/PubnubSubsystem.h | 4 ++-- 3 files changed, 9 insertions(+), 23 deletions(-) delete mode 100644 Config/FilterPlugin.ini diff --git a/Config/FilterPlugin.ini b/Config/FilterPlugin.ini deleted file mode 100644 index ccebca2..0000000 --- a/Config/FilterPlugin.ini +++ /dev/null @@ -1,8 +0,0 @@ -[FilterPlugin] -; This section lists additional files which will be packaged along with your plugin. Paths should be listed relative to the root plugin directory, and -; may include "...", "*", and "?" wildcards to match directories, files, and individual characters respectively. -; -; Examples: -; /README.txt -; /Extras/... -; /Binaries/ThirdParty/*.dll diff --git a/Source/PubnubLibrary/Private/PubnubSubsystem.cpp b/Source/PubnubLibrary/Private/PubnubSubsystem.cpp index f4f6ec4..52751cd 100644 --- a/Source/PubnubLibrary/Private/PubnubSubsystem.cpp +++ b/Source/PubnubLibrary/Private/PubnubSubsystem.cpp @@ -465,14 +465,14 @@ void UPubnubSubsystem::RemoveMemberships(FString UUIDMetadataID, FString Include } void UPubnubSubsystem::GetChannelMembers(FString ChannelMetadataID, FString Include, int Limit, FString Start, FString End, - EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse, FString Filter) + EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse) { if(!CheckQuickActionThreadValidity()) {return;} - QuickActionThread->AddFunctionToQueue( [this, ChannelMetadataID, Include, Limit, Start, End, Count, OnGetMembersResponse, Filter] + QuickActionThread->AddFunctionToQueue( [this, ChannelMetadataID, Include, Limit, Start, End, Count, OnGetMembersResponse] { - GetChannelMembers_priv(ChannelMetadataID, Include, Limit, Start, End, Count, OnGetMembersResponse, Filter); + GetChannelMembers_priv(ChannelMetadataID, Include, Limit, Start, End, Count, OnGetMembersResponse); }); } @@ -1708,8 +1708,7 @@ void UPubnubSubsystem::RemoveMemberships_priv(FString UUIDMetadataID, FString In } } -void UPubnubSubsystem::GetChannelMembers_priv(FString ChannelMetadataID, FString Include, int Limit, FString Start, - FString End, EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse, FString Filter) +void UPubnubSubsystem::GetChannelMembers_priv(FString ChannelMetadataID, FString Include, int Limit, FString Start, FString End, EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse) { if(!CheckIsPubnubInitialized() || !CheckIsUserIDSet()) {return;} @@ -1718,14 +1717,9 @@ void UPubnubSubsystem::GetChannelMembers_priv(FString ChannelMetadataID, FString {return;} pubnub_tribool InCount = (pubnub_tribool)(uint8)Count; - if(Filter.IsEmpty()) - { - pubnub_get_members(ctx_pub,TCHAR_TO_ANSI(*ChannelMetadataID), TCHAR_TO_ANSI(*Include), Limit, TCHAR_TO_ANSI(*Start), TCHAR_TO_ANSI(*End), InCount); - } - else - { - pubnub_get_members_with_filter(ctx_pub,TCHAR_TO_ANSI(*ChannelMetadataID), TCHAR_TO_ANSI(*Include), Limit, TCHAR_TO_ANSI(*Start), TCHAR_TO_ANSI(*End), TCHAR_TO_ANSI(*Filter), InCount); - } + + pubnub_get_members(ctx_pub,TCHAR_TO_ANSI(*ChannelMetadataID), TCHAR_TO_ANSI(*Include), Limit, TCHAR_TO_ANSI(*Start), TCHAR_TO_ANSI(*End), InCount); + FString JsonResponse = GetLastResponse(ctx_pub); //Delegate needs to be executed back on Game Thread diff --git a/Source/PubnubLibrary/Public/PubnubSubsystem.h b/Source/PubnubLibrary/Public/PubnubSubsystem.h index 9b126c2..d8d6066 100644 --- a/Source/PubnubLibrary/Public/PubnubSubsystem.h +++ b/Source/PubnubLibrary/Public/PubnubSubsystem.h @@ -169,7 +169,7 @@ class PUBNUBLIBRARY_API UPubnubSubsystem : public UGameInstanceSubsystem void RemoveMemberships(FString UUIDMetadataID, FString Include, FString RemoveObj); UFUNCTION(BlueprintCallable, Category = "Pubnub|AppContext") - void GetChannelMembers(FString ChannelMetadataID, FString Include, int Limit, FString Start, FString End, EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse, FString Filter); + void GetChannelMembers(FString ChannelMetadataID, FString Include, int Limit, FString Start, FString End, EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse); UFUNCTION(BlueprintCallable, Category = "Pubnub|AppContext") void AddChannelMembers(FString ChannelMetadataID, FString Include, FString AddObj); @@ -319,7 +319,7 @@ class PUBNUBLIBRARY_API UPubnubSubsystem : public UGameInstanceSubsystem void GetMemberships_priv(FString UUIDMetadataID, FString Include, int Limit, FString Start, FString End, EPubnubTribool Count, FOnPubnubResponse OnGetMembershipResponse); void SetMemberships_priv(FString UUIDMetadataID, FString Include, FString SetObj); void RemoveMemberships_priv(FString UUIDMetadataID, FString Include, FString RemoveObj); - void GetChannelMembers_priv(FString ChannelMetadataID, FString Include, int Limit, FString Start, FString End, EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse, FString Filter); + void GetChannelMembers_priv(FString ChannelMetadataID, FString Include, int Limit, FString Start, FString End, EPubnubTribool Count, FOnPubnubResponse OnGetMembersResponse); void AddChannelMembers_priv(FString ChannelMetadataID, FString Include, FString AddObj); void SetChannelMembers_priv(FString ChannelMetadataID, FString Include, FString SetObj); void RemoveChannelMembers_priv(FString ChannelMetadataID, FString Include, FString RemoveObj);