refactor: enhance explicit timetoken subscribe request handling (#248)

mohitpubnub · Mohit Tejani · pubnub-release-bot · web-flow · commit 3094f660a924 · 2025-04-08T05:59:36.000+02:00
* refactor: log statements in HttpClientService.
condition update to make tt=0 calls when explicitly mentioned.

* PubNub SDK v7.3.8.0 release.

---------

Co-authored-by: Mohit Tejani &lt;mohit.tejani@Mohits-MacBook-Pro.local&gt;
Co-authored-by: PubNub Release Bot &lt;120067856+pubnub-release-bot@users.noreply.github.com&gt;
diff --git a/.pubnub.yml b/.pubnub.yml
@@ -1,8 +1,13 @@
 name: c-sharp
-version: "7.3.7"
+version: "7.3.8"
 schema: 1
 scm: github.com/pubnub/c-sharp
 changelog:
+  - date: 2025-04-08
+    version: v7.3.8
+    changes:
+      - type: improvement
+        text: "Subscribe with custom timetoken scenario handling improvements."
   - date: 2025-04-07
     version: v7.3.7
     changes:
@@ -882,7 +887,7 @@ features:
     - QUERY-PARAM
 supported-platforms:
   -
-    version: Pubnub 'C#' 7.3.7
+    version: Pubnub 'C#' 7.3.8
     platforms:
       - Windows 10 and up
       - Windows Server 2008 and up
@@ -893,7 +898,7 @@ supported-platforms:
       - .Net Framework 4.6.1+
       - .Net Framework 6.0
   -
-    version: PubnubPCL 'C#' 7.3.7
+    version: PubnubPCL 'C#' 7.3.8
     platforms:
       - Xamarin.Android
       - Xamarin.iOS
@@ -913,7 +918,7 @@ supported-platforms:
       - .Net Core
       - .Net 6.0
   -
-    version: PubnubUWP 'C#' 7.3.7
+    version: PubnubUWP 'C#' 7.3.8
     platforms:
       - Windows Phone 10
       - Universal Windows Apps
@@ -937,7 +942,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: Pubnub
-            location: https://github.com/pubnub/c-sharp/releases/tag/v7.3.7.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v7.3.8.0
             requires:
               -
                 name: ".Net"
@@ -1220,7 +1225,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: PubNubPCL
-            location: https://github.com/pubnub/c-sharp/releases/tag/v7.3.7.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v7.3.8.0
             requires:
               -
                 name: ".Net Core"
@@ -1579,7 +1584,7 @@ sdks:
             distribution-type: source
             distribution-repository: GitHub
             package-name: PubnubUWP
-            location: https://github.com/pubnub/c-sharp/releases/tag/v7.3.7.0
+            location: https://github.com/pubnub/c-sharp/releases/tag/v7.3.8.0
             requires:
               -
                 name: "Universal Windows Platform Development"
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,7 @@
+v7.3.8 - April 08 2025
+-----------------------------
+- Modified: subscribe with custom timetoken scenario handling improvements.
+
 v7.3.7 - April 07 2025
 -----------------------------
 - Modified: enhance request handling with detailed response interface.
diff --git a/src/Api/PubnubApi/EndPoint/PubSub/SubscribeEndpoint.cs b/src/Api/PubnubApi/EndPoint/PubSub/SubscribeEndpoint.cs
@@ -107,7 +107,7 @@ public void Execute()
 			string[] channelNames = subscribeChannelNames != null ? this.subscribeChannelNames.ToArray() : null;
 			string[] channelGroupNames = subscribeChannelGroupNames != null ? this.subscribeChannelGroupNames.ToArray() : null;
 			SubscriptionCursor cursor = null;
-			if (subscribeTimetoken >= 1) {
+			if (subscribeTimetoken >= 0) {
 				cursor = new SubscriptionCursor { Timetoken = subscribeTimetoken, Region = 0 };
 			}
 			Subscribe(channelNames, channelGroupNames, cursor, this.queryParam);
diff --git a/src/Api/PubnubApi/EventEngine/Subscribe/States/ReceivingState.cs b/src/Api/PubnubApi/EventEngine/Subscribe/States/ReceivingState.cs
@@ -42,7 +42,8 @@ public override TransitionResult Transition(IEvent e)
                     Channels = subscriptionRestored.Channels,
                     ChannelGroups = subscriptionRestored.ChannelGroups,
                     Cursor = subscriptionRestored.Cursor,
-                },
+                }.With(
+                    new EmitStatusInvocation(new PNStatus(null,PNOperationType.PNSubscribeOperation, PNStatusCategory.PNSubscriptionChangedCategory, subscriptionRestored.Channels?? new string[]{}, subscriptionRestored.ChannelGroups?? new string[]{}, Constants.HttpRequestSuccessStatusCode))),
 
                 Events.DisconnectEvent disconnect => new ReceiveStoppedState()
                 {
diff --git a/src/Api/PubnubApi/Properties/AssemblyInfo.cs b/src/Api/PubnubApi/Properties/AssemblyInfo.cs
@@ -11,8 +11,8 @@
 [assembly: AssemblyProduct("Pubnub C# SDK")]
 [assembly: AssemblyCopyright("Copyright ©  2021")]
 [assembly: AssemblyTrademark("")]
-[assembly: AssemblyVersion("7.3.7.0")]
-[assembly: AssemblyFileVersion("7.3.7.0")]
+[assembly: AssemblyVersion("7.3.8.0")]
+[assembly: AssemblyFileVersion("7.3.8.0")]
 // Setting ComVisible to false makes the types in this assembly not visible
 // to COM components.  If you need to access a type in this assembly from
 // COM, set the ComVisible attribute to true on that type.
diff --git a/src/Api/PubnubApi/PubnubApi.csproj b/src/Api/PubnubApi/PubnubApi.csproj
@@ -14,15 +14,15 @@
 
   <PropertyGroup>
     <PackageId>Pubnub</PackageId>
-    <PackageVersion>7.3.7.0</PackageVersion>
+    <PackageVersion>7.3.8.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Enhance request handling with detailed response interface.</PackageReleaseNotes>
+    <PackageReleaseNotes>Subscribe with custom timetoken scenario handling improvements.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>
diff --git a/src/Api/PubnubApi/Transport/HttpClientService.cs b/src/Api/PubnubApi/Transport/HttpClientService.cs
@@ -398,12 +398,12 @@ private TransportResponse GetTransportResponseForTaskCancelation(TransportReques
             if (ctsWithTimeout is { Token.IsCancellationRequested: true } &&
                 !transportRequest.CancellationTokenSource.IsCancellationRequested)
             {
-                logger?.Debug("\n\n\n\n  TASK TIMEOUT NETWORK ERROR \n\n\n\n\n");
+                logger?.Debug("HttpClient Service: Task canceled due to timeout");
                 transportResponse.IsTimeOut = true;
             }
             else
             {
-                logger?.Debug("\n\n\n\n  TASK CANCELLED \n\n\n\n\n");
+                logger?.Debug("HttpClient Service: Task canceled due to cancellation request");
                 transportResponse.IsCancelled = true;
             }
             return transportResponse;
diff --git a/src/Api/PubnubApiPCL/PubnubApiPCL.csproj b/src/Api/PubnubApiPCL/PubnubApiPCL.csproj
@@ -14,15 +14,15 @@
 
   <PropertyGroup>
     <PackageId>PubnubPCL</PackageId>
-    <PackageVersion>7.3.7.0</PackageVersion>
+    <PackageVersion>7.3.8.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Enhance request handling with detailed response interface.</PackageReleaseNotes>
+    <PackageReleaseNotes>Subscribe with custom timetoken scenario handling improvements.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>
diff --git a/src/Api/PubnubApiUWP/PubnubApiUWP.csproj b/src/Api/PubnubApiUWP/PubnubApiUWP.csproj
@@ -16,15 +16,15 @@
 
   <PropertyGroup>
     <PackageId>PubnubUWP</PackageId>
-    <PackageVersion>7.3.7.0</PackageVersion>
+    <PackageVersion>7.3.8.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
-    <PackageReleaseNotes>Enhance request handling with detailed response interface.</PackageReleaseNotes>
+    <PackageReleaseNotes>Subscribe with custom timetoken scenario handling improvements.</PackageReleaseNotes>
     <PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
     <!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
     <Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games.  This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>
diff --git a/src/Api/PubnubApiUnity/PubnubApiUnity.csproj b/src/Api/PubnubApiUnity/PubnubApiUnity.csproj
@@ -14,7 +14,7 @@
 
   <PropertyGroup>
     <PackageId>PubnubApiUnity</PackageId>
-    <PackageVersion>7.3.7.0</PackageVersion>
+    <PackageVersion>7.3.8.0</PackageVersion>
     <Title>PubNub C# .NET - Web Data Push API</Title>
     <Authors>Pandu Masabathula</Authors>
     <Owners>PubNub</Owners>

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public void Execute()`
`107`	`107`	`string[] channelNames = subscribeChannelNames != null ? this.subscribeChannelNames.ToArray() : null;`
`108`	`108`	`string[] channelGroupNames = subscribeChannelGroupNames != null ? this.subscribeChannelGroupNames.ToArray() : null;`
`109`	`109`	`SubscriptionCursor cursor = null;`
`110`		`- if (subscribeTimetoken >= 1) {`
	`110`	`+ if (subscribeTimetoken >= 0) {`
`111`	`111`	`cursor = new SubscriptionCursor { Timetoken = subscribeTimetoken, Region = 0 };`
`112`	`112`	`}`
`113`	`113`	`Subscribe(channelNames, channelGroupNames, cursor, this.queryParam);`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,8 @@ public override TransitionResult Transition(IEvent e)`
`42`	`42`	`Channels = subscriptionRestored.Channels,`
`43`	`43`	`ChannelGroups = subscriptionRestored.ChannelGroups,`
`44`	`44`	`Cursor = subscriptionRestored.Cursor,`
`45`		`- },`
	`45`	`+ }.With(`
	`46`	`+ new EmitStatusInvocation(new PNStatus(null,PNOperationType.PNSubscribeOperation, PNStatusCategory.PNSubscriptionChangedCategory, subscriptionRestored.Channels?? new string[]{}, subscriptionRestored.ChannelGroups?? new string[]{}, Constants.HttpRequestSuccessStatusCode))),`
`46`	`47`
`47`	`48`	`Events.DisconnectEvent disconnect => new ReceiveStoppedState()`
`48`	`49`	`{`
Original file line number	Diff line number	Diff line change
`@@ -398,12 +398,12 @@ private TransportResponse GetTransportResponseForTaskCancelation(TransportReques`
`398`	`398`	`if (ctsWithTimeout is { Token.IsCancellationRequested: true } &&`
`399`	`399`	`!transportRequest.CancellationTokenSource.IsCancellationRequested)`
`400`	`400`	`{`
`401`		`- logger?.Debug("\n\n\n\n TASK TIMEOUT NETWORK ERROR \n\n\n\n\n");`
	`401`	`+ logger?.Debug("HttpClient Service: Task canceled due to timeout");`
`402`	`402`	`transportResponse.IsTimeOut = true;`
`403`	`403`	`}`
`404`	`404`	`else`
`405`	`405`	`{`
`406`		`- logger?.Debug("\n\n\n\n TASK CANCELLED \n\n\n\n\n");`
	`406`	`+ logger?.Debug("HttpClient Service: Task canceled due to cancellation request");`
`407`	`407`	`transportResponse.IsCancelled = true;`
`408`	`408`	`}`
`409`	`409`	`return transportResponse;`