-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electric-sql to the client-side-databases project to measure the performance metrics. #5589
Comments
Thank you @mattriese
|
udpate: I would like another couple weeks to finish this. |
@mattriese No problems, thanks for the update. |
Update: How will I make a PR when it is working? will you grant me write access to this repo? Also, when I try to run the projects in this repo and use them in the browser, only the Firebase projects works. And it only fully works in production mode. In dev mode it does not load the chat history, but I can add new messages. All the other projects get stuck on the loading spinner after I enter my name. (I haven't tried the AWS project because of the extra steps). The e2e tests do seem to run fine, though. |
Just make a single PR and I will merge it. For your problems, maybe you want to clear the browser state in the "applications" tab in the dev tools. That might help. The projects build in the CI and the tests work, so it should be also working for you. |
Hi @mattriese |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem. Notice that only bugs in the rxdb premium plugins are ensured to be fixed by the maintainer. Everything else is expected to be fixed by the community, likely you must fix it by yourself. |
@mattriese the PRs at the electric repo seem to be fixed/closed. |
Ah yeah, I just noticed they released it with [email protected]. I'll try to wrap this up this week |
I've created a draft PR to show my progress so far. There's a sqlite error when I try to load the app and the tests seem to have another problem. Any advice would be appreciated :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem. Notice that only bugs in the rxdb premium plugins are ensured to be fixed by the maintainer. Everything else is expected to be fixed by the community, likely you must fix it by yourself. |
I solved one of the problems and narrowed down the cause of the other. see the new comments in the PR If you have any wisdom around loading wasm files in a way that's compatible with Angular and testCafe, please let me know! :) |
@mattriese On some projects I am spawning a different server just to serve static files to testcafe browsers. I am not sure if that is the only possible solution. Maybe bundling the wasm file into a base64 is an option, but that might impact the performance results. |
@pubkey Ok thanks for the suggestions I will give it a shot |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem. Notice that only bugs in the rxdb premium plugins are ensured to be fixed by the maintainer. Everything else is expected to be fixed by the community, likely you must fix it by yourself. |
Update: I didn't get any responses to my question in the Electric-SQL discord about this issue. I tried the suggestion of spawning a separate express server just to serve the wasm files, and that did work in dev mode but when running the tests I got the same error (TypeError: cannot read properties of |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. Please update it or it may be closed to keep our repository organized. The best way is to add some more information or make a pull request with a test case. Also you might get help in fixing it at the RxDB Community Chat If you know you will continue working on this, just write any message to the issue (like "ping") to remove the stale tag. |
@pubkey hey I just wanted to make sure you saw my last update on here. |
@mattriese yes I have seen it. There is no hurry, just ping me when you want to continue. |
Ok gotcha. I don't have any immediate plans to continue working on this by myself, but if I do I will let you know. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. Please update it or it may be closed to keep our repository organized. The best way is to add some more information or make a pull request with a test case. Also you might get help in fixing it at the RxDB Community Chat If you know you will continue working on this, just write any message to the issue (like "ping") to remove the stale tag. |
Issues are autoclosed after some time. If you still have a problem, make a PR with a test case or to prove that you have tried to fix the problem. |
Add electric-sql to the client-side-databases project to measure the performance metrics.
For that, create an angular subproject like the already existing ones and then implement the logic interface.
I plan to be done with this on Feb 11th.
The text was updated successfully, but these errors were encountered: