Did flags like IMGUI_DISABLE_OBSOLETE_FUNCTIONS be considered when the binding was built?

[davidlatwe]

Hi, this project is amazing, so is litgen!

So, imgui.h has following lines within struct ImGuiIO:

// Since 1.90, defining IMGUI_DISABLE_OBSOLETE_FUNCTIONS automatically defines IMGUI_DISABLE_OBSOLETE_KEYIO as well.  
#if defined(IMGUI_DISABLE_OBSOLETE_FUNCTIONS) && !defined(IMGUI_DISABLE_OBSOLETE_KEYIO)  
#define IMGUI_DISABLE_OBSOLETE_KEYIO  
#endif

And these:

    ImVec2      MouseDelta;                         // Mouse delta. Note that this is zero if either current or previous position are invalid (-FLT_MAX,-FLT_MAX), so a disappearing/reappearing mouse won't have a huge delta.

    // Legacy: before 1.87, we required backend to fill io.KeyMap[] (imgui->native map) during initialization and io.KeysDown[] (native indices) every frame.
    // This is still temporarily supported as a legacy feature. However the new preferred scheme is for backend to call io.AddKeyEvent().
    //   Old (<1.87):  ImGui::IsKeyPressed(ImGui::GetIO().KeyMap[ImGuiKey_Space]) --> New (1.87+) ImGui::IsKeyPressed(ImGuiKey_Space)
#ifndef IMGUI_DISABLE_OBSOLETE_KEYIO
    int         KeyMap[ImGuiKey_COUNT];             // [LEGACY] Input: map of indices into the KeysDown[512] entries array which represent your "native" keyboard state. The first 512 are now unused and should be kept zero. Legacy backend will write into KeyMap[] using ImGuiKey_ indices which are always >512.
    bool        KeysDown[ImGuiKey_COUNT];           // [LEGACY] Input: Keyboard keys that are pressed (ideally left in the "native" order your engine has access to keyboard keys, so you can use your own defines/enums for keys). This used to be [512] sized. It is now ImGuiKey_COUNT to allow legacy io.KeysDown[GetKeyIndex(...)] to work without an overflow.
    float       NavInputs[ImGuiNavInput_COUNT];     // [LEGACY] Since 1.88, NavInputs[] was removed. Backends from 1.60 to 1.86 won't build. Feed gamepad inputs via io.AddKeyEvent() and ImGuiKey_GamepadXXX enums.
#endif

    //------------------------------------------------------------------
    // [Internal] Dear ImGui will maintain those fields. Forward compatibility not guaranteed!
    //------------------------------------------------------------------

    ImGuiContext* Ctx;                              // Parent UI context (needs to be set explicitly by parent).

Then I found KeyMap, KeysDown, NavInputs, they were omitted from here:

imgui_bundle/external/imgui/bindings/pybind_imgui.cpp

Lines 5168 to 5169 in df46333

	.def_readwrite("mouse_delta", &ImGuiIO::MouseDelta, "")
	.def_readwrite("ctx", &ImGuiIO::Ctx, "Parent UI context (needs to be set explicitly by parent).")

Which means, IMGUI_DISABLE_OBSOLETE_FUNCTIONS or IMGUI_DISABLE_OBSOLETE_KEYIO must be defined somewhere when generating the binding. But I cannot find it.

Where are they?

Thanks. :)

[pthom]

Hello,

Many thanks for the compliments!

The answer to your question is here

So, this means that IMGUI_DISABLE_OBSOLETE_FUNCTIONS was not added to options.srcmlcpp_options.header_filter_acceptable__regex, because I considered those as arcane options when publishing the bindings.

[davidlatwe]

Ah! There it is!

imgui_bundle/external/imgui/bindings/litgen_options_imgui.py

Line 265 in df46333

options.srcmlcpp_options.header_filter_acceptable__regex += "|^IMGUI_DISABLE$"

Thank you so much for this quick answer ❤️