Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to edit the structure class #152

Closed
proycon opened this issue Jul 18, 2019 · 6 comments
Closed

Add the ability to edit the structure class #152

proycon opened this issue Jul 18, 2019 · 6 comments
Assignees
Milestone

Comments

@proycon
Copy link
Owner

proycon commented Jul 18, 2019

When clicking a word or other structural element, you can only edit annotations under it, rather than the structural annotation itself. Implement a facility to edit the class (and underlying features) of the structural element.

Assigning classes and features to Figures may be relevant for @ErkanBasar and @sbrugman as an alternative to metric annotation (#151).

@proycon proycon added this to the v0.9.0 milestone Jul 18, 2019
@proycon proycon self-assigned this Jul 18, 2019
proycon added a commit that referenced this issue Jul 23, 2019
…into separate functions), implementing support to edit the structure class in the form (#152); also implemented a fallback in case a set definition does not define labels.
@proycon
Copy link
Owner Author

proycon commented Jul 30, 2019

  • Fix submission of structure class edit
  • Add toggle option to enable/disable structure class editing

@luutuntin
Copy link

Hi Maarten, does this ability allow us, for example, to add a new sentence to a document opened in FLAT? If yes, how do we do that?

@luutuntin
Copy link

luutuntin commented Oct 15, 2019

Oh, this ability is just for structure class annotation, such as different types of words or sentences, right? (And the task I asked in my previous message should be handled by Structure Editor, which is in under development.)

@proycon
Copy link
Owner Author

proycon commented Oct 15, 2019

Yes, precisely. There haven't been many requests for the structure editor yet (thought it's been proposed for a long time already), so if you're interesting I'll bump it a bit higher on the priority list?

@proycon
Copy link
Owner Author

proycon commented Oct 15, 2019

(cross-referencing #5)

@luutuntin
Copy link

luutuntin commented Oct 15, 2019

Thanks. On the one hand, we do have the real use cases that clearly benefit from the structure editor (e.g. a morphological annotator found out there was a whole utterance missing from transcription stage and therefore needed to add it to both the transcript (ELAN file) and the morphological annotation (FoLiA file)). On the other hand, these use cases are rare enough for manual handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants