add: user picture #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better if there was a data type for pictures. It may be misleading fetching a value this deep on the structure. What are the reasons for doing the deep fetch? |
|
Fixed and force pushed. |
| @@ -33,6 +33,14 @@ import Facebook.Object.Checkin | |||
| -- /NOTE:/ We still don't support all fields supported by | |||
| -- Facebook. Please fill an issue if you need access to any other | |||
| -- fields. | |||
| data Picture = | |||
There was a problem hiding this comment.
The Picture data type is declared between the comment for User and the User datatype itself.
The Picture data type should either be declared above the comment for User, or below the User datatype. It would be best if it had a comment as well.
|
@cdepillabout fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.