Filters for tunnel style layers

[alundeen]

Hi! Thanks for the great library.

I noticed most of the roads_tunnels_ layers in the style use ["has", "is_tunnel"] as part of their filter, which makes sense to me. However, these layers seem to be doing the opposite:

{
  id: "roads_tunnels_major_casing",
  filter: [
    "all",
    ["!has", "is_tunnel"],
    ["!has", "is_bridge"],
    ["==", "kind", "major_road"],
  ],
  // ...
}

{
  id: "roads_tunnels_highway_casing",
  filter: [
    "all",
    ["!has", "is_tunnel"],
    ["!has", "is_bridge"],
    ["==", "kind", "highway"],
    ["!has", "is_link"],
  ],
  // ...
}

These filters seem to be the opposite of what I'd expect for tunnel layers, and appear to be adding a very faint dashed line to most major roads and highways on the map.

Are these filters incorrect here, or am I misunderstanding the purpose? Thanks!

[wipfli]

You are right the filters are the wrong way round!

[bdon]

Created PR #565

[bdon]

Updated appearance for highway tunnels

[bdon]

I released the fix in v5.7.1, thanks!

[alundeen]

Great, thank you!