Skip to content

Commit 88ce802

Browse files
authored
Merge pull request #21 from protegeproject/19-getchildren-entitycomments-and-entityhistorysummary-should-also-contain-entityiri-and-projectid-in-the-response
fix for who-icatx/icatx-api-gateway#19
2 parents 175981a + f6fcbb4 commit 88ce802

File tree

2 files changed

+27
-13
lines changed

2 files changed

+27
-13
lines changed
Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
11
package edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.dto;
22

3+
import com.fasterxml.jackson.annotation.JsonProperty;
4+
35
import java.util.List;
46

5-
public record EntityHistorySummary(List<EntityChange> changes) {
6-
public static EntityHistorySummary create(List<EntityChange> changes) {
7-
return new EntityHistorySummary(changes);
7+
public record EntityHistorySummary(@JsonProperty("entityUri") String entityUri,
8+
@JsonProperty("projectId") String projectId,
9+
@JsonProperty("changes") List<EntityChange> changes) {
10+
public static EntityHistorySummary create(String entityUri,
11+
String projectId,
12+
List<EntityChange> changes) {
13+
return new EntityHistorySummary(entityUri, projectId, changes);
814
}
915
}

src/main/java/edu/stanford/protege/webprotegeeventshistory/uiHistoryConcern/services/NewRevisionsEventServiceImpl.java

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,27 @@
22

33
import edu.stanford.protege.webprotege.change.ProjectChange;
44
import edu.stanford.protege.webprotege.common.Page;
5-
import edu.stanford.protege.webprotege.common.*;
6-
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.dto.*;
7-
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.events.*;
8-
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.mappers.*;
5+
import edu.stanford.protege.webprotege.common.ProjectId;
6+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.dto.ChangeType;
7+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.dto.ChangedEntities;
8+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.dto.EntityChange;
9+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.dto.EntityHistorySummary;
10+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.events.NewRevisionsEvent;
11+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.events.RevisionsEvent;
12+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.mappers.ProjectChangeMapper;
13+
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.mappers.RevisionEventMapper;
914
import edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.repositories.RevisionsEventRepository;
1015
import org.semanticweb.owlapi.model.OWLEntity;
11-
import org.springframework.data.domain.PageRequest;
1216
import org.springframework.data.domain.*;
1317
import org.springframework.stereotype.Service;
1418
import org.springframework.transaction.annotation.Transactional;
1519

16-
import java.time.*;
17-
import java.util.*;
20+
import java.time.Instant;
21+
import java.time.LocalDateTime;
22+
import java.time.ZoneId;
23+
import java.util.List;
24+
import java.util.Objects;
25+
import java.util.Optional;
1826
import java.util.stream.Collectors;
1927

2028
import static edu.stanford.protege.webprotegeeventshistory.uiHistoryConcern.events.RevisionsEvent.*;
@@ -92,9 +100,9 @@ public ChangedEntities getChangedEntitiesAfterTimestamp(ProjectId projectId, lon
92100
return new ChangedEntities(createdEntities, updatedEntities, deletedEntities);
93101
}
94102

95-
private static List<String> groupByChangeType(List<RevisionsEvent> revisionsEvents, ChangeType createEntity) {
103+
private static List<String> groupByChangeType(List<RevisionsEvent> revisionsEvents, ChangeType changeType) {
96104
return revisionsEvents.stream()
97-
.filter(event -> event.changeType() == createEntity)
105+
.filter(event -> event.changeType() == changeType)
98106
.map(RevisionsEvent::whoficEntityIri)
99107
.filter(Objects::nonNull)
100108
.distinct()
@@ -114,6 +122,6 @@ public EntityHistorySummary getEntityHistorySummary(ProjectId projectId, String
114122
).toList();
115123

116124

117-
return EntityHistorySummary.create(entityChanges);
125+
return EntityHistorySummary.create(entityIri, projectId.value(), entityChanges);
118126
}
119127
}

0 commit comments

Comments
 (0)