Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OOPS! Evaluator plugin in autoupdate repo #14

Closed
lukasged opened this issue Jan 20, 2017 · 7 comments
Closed

Add OOPS! Evaluator plugin in autoupdate repo #14

lukasged opened this issue Jan 20, 2017 · 7 comments

Comments

@lukasged
Copy link
Contributor

Hi,

I've developed a plugin for ontology evaluation as the final project for my Master's Degree. Its update.properties file is located here

I would like to add it to the autoupdate registry.

lukasged added a commit to lukasged/autoupdate that referenced this issue Jan 20, 2017
@csnyulas
Copy link
Member

Is this plugin compatible with Protege 5.0? Should we added it also to the (end of) https://github.com/protegeproject/autoupdate/blob/master/update-info/5.0.0/plugins.repository file?

@lukasged
Copy link
Contributor Author

I´ve specified Protege 5.1.0 for the dependencies in the pom.xml file so I think it´s only compatible with Protege 5.1.0 for now (I tried to run the plugin under 5.0.0 and I couldn´t get to start the plugin´s tab). I've also used some classes in the code that are only available for the 5.1.0 version but I think I could make it compatible with the 5.0.0 version by avoiding that code.

By the way, I still can't see my plugin in the autoupdate, even after the merged pull request. Does it only connect to the https://github.com/protegeproject/autoupdate/blob/master/update-info/5.0.0/plugins.repository file? In my Protege 5.1.0 log, when I click "Check for plugins..." and then check the logs for the autoupdate entries, I can only see:
Processing https://raw.githubusercontent.com/protegeproject/autoupdate/master/update-info/5.0.0/plugins.repository as a plugin registry

@lukasged
Copy link
Contributor Author

I gave it a try to make it compatible with 5.0.0 but it doesn't seem trivial. I managed to make it compatible to 5.0.0, but that change created issues when ran on the 5.1.0 version. The issue is related with the changes introduced in this issue. My plugin's UI is based on the Entities tab UI (check the image at the bottom of the comment), and the mentioned issue changes its behaviour related to the selection of entities.

I think that for now I'll have to leave it compatible with 5.0.0 only, but will it appear in the autoupdate?

image

@csnyulas
Copy link
Member

Don't worry about 5.0. It was only an idea, in case it was trivial. We encourage people to install the latest Protégé anyway, and having this plug-in available for 5.1 only, will provide an extra motivation to our users. I can't think of any reason for why someone having v5.0 installed would not be able to upgrade to v5.1 (5.1 does not introduce any additional system requirement on top of 5.0).

@lukasged
Copy link
Contributor Author

Thanks for the comments @csnyulas , but did I did something wrong with the pull request related to my plugin being added to the autoupdate? At least in my case, it doesn't show up in the suggested plugins list from the autoupdate.

@csnyulas
Copy link
Member

You were right @lukasged. There was indeed a problem because we added the reference to your update.properties file in the wrong plugin.repository. It turns out that the https://github.com/protegeproject/autoupdate/blob/master/update-info/5.0.0/plugins.repository file is the one read by all Protege 5.x versions, including version 5.1.0. I discussed this briefly with @matthewhorridge, and he says that this is designed to be so, and the main plugins.repository file is for Protege 4.x (and he just made a note for that), and could not be moved somewhere else because of backwards compatibility.

Right now out team is extremely busy with other things, but I create an issue (#16) to revisit this.

BTW, Protégé can now find your plug-in and I can easily install it. I found a minor problem with it, that I documented here: lukasged/oops-plugin#7

@lukasged
Copy link
Contributor Author

Great, I can also see my plugin in the autoupdate at last! 👍

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants