Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record the version within generated modelscan-settings files #80

Open
1 of 2 tasks
seanpmorgan opened this issue Jan 12, 2024 · 1 comment
Open
1 of 2 tasks

Record the version within generated modelscan-settings files #80

seanpmorgan opened this issue Jan 12, 2024 · 1 comment
Labels
configuration enhancement New feature or request
Milestone

Comments

@seanpmorgan
Copy link
Member

seanpmorgan commented Jan 12, 2024

We need to record which version was used to generate a modelscan-settings.toml file so that

  • We can warn users that their current settings file may have out-of-date scanners
  • We can version our settings file schema and easily handle breaking changes
@seanpmorgan
Copy link
Member Author

seanpmorgan commented Jan 22, 2024

Currently this is the behavior for using an old settings file after the scanner re-name:

Detected settings file. Using ~/modelscan-settings.toml. 

Error importing scanner modelscan.scanners.H5Scan
Error importing scanner modelscan.scanners.KerasScan
Error importing scanner modelscan.scanners.NumpyScan
Error importing scanner modelscan.scanners.PickleScan
Error importing scanner modelscan.scanners.PyTorchScan

That should be more informative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant