Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NumPy an optional dependency #79

Open
seanpmorgan opened this issue Jan 12, 2024 · 0 comments
Open

Make NumPy an optional dependency #79

seanpmorgan opened this issue Jan 12, 2024 · 0 comments
Labels
build good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v1.0 Release

Comments

@seanpmorgan
Copy link
Member

NumPy is only required when scanning certain file extensions:
https://github.com/protectai/modelscan/blob/v0.4.2/modelscan/scanners/pickle/scan.py#L47-L55

We should make NumPy an optional requirement, just as we've done with TensorFlow so that users are not forced to install heavy dependencies they don't plan to use.
@seanpmorgan seanpmorgan added good first issue Good for newcomers help wanted Extra attention is needed build labels Jan 12, 2024
@seanpmorgan seanpmorgan added this to the v1.0 Release milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v1.0 Release
Development

No branches or pull requests
1 participant
@seanpmorgan