-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated function usages #350
Comments
Would it be ok to bump the symfony min version from 2.5 to 2.7? The fixes would be simpler. |
Is there any technical reason for the required changes (didn't have a look at them by now) to raise the dependency version? I'm against it, as there are probably applications out there, which do not require 2.7. Which is fine, if they don't have needs for it. So if this bundle does not require 2.7, we are not in charge or responsibility to raise the dependency for any application using this bundle. |
There are symfony 2.8, in witch forms do no work. |
I'm on the current move: There is a new branch 1.5 which raises the dependency to Symfony 2.8, which is the current LTS. I gave it a lot of thoughts, and this step is fine, we commit on an LTS and this will be easier to support on a new branch, while leaving the old branches. The old ones will only receive an update on the incompatibility of their respective Symfony versions. The second branch (not created yet) will be 1.6, which will be Symfony 3.0 compatible, but 2.8 incompatible. |
The former Propel1 bridge of the symfony package has been merged. In case you are still up to it, the 1.5 branch is ready for the changes. The distributed phpunit.xml.dist disables the deprecation errors, you have to change the error level. |
@havvg I forgot to mention in my initial post that I'm talking about the propel 2.x version. |
@gharlan I would suggest |
There are some deprecated (since SF 2.7) function usages which should be fixed.
Examples:
The text was updated successfully, but these errors were encountered: