Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent validation issues with issuers fields without choices #47

Open
rvdsteege opened this issue Jan 10, 2025 · 1 comment · May be fixed by #48
Open

Prevent validation issues with issuers fields without choices #47

rvdsteege opened this issue Jan 10, 2025 · 1 comment · May be fixed by #48
Assignees

Comments

@rvdsteege
Copy link
Member

rvdsteege commented Jan 10, 2025

In pronamic/wp-pronamic-pay-mollie#53 (comment) it was suggested to remove iDEAL issuers from the https://github.com/pronamic/wp-pronamic-pay-mollie/ integration. And the same in:

However, if we suddenly remove the iDEAL issuers and forms are not updated yet, validation issues will occur with issuers fields marked as 'required' and users will be unable to submit the form:

Image

To prevent these issues, we can remove issuers fields without choices from the form and mark them as valid during validation, as these are no longer needed.

@remcotolsma
Copy link
Member

I don't know if it's smart for integrations like this to remove fields from forms. If there are references (in text or code) to this field in the form, will other problems arise? Falling back to https://github.com/pronamic/ideal-issuers might be a safer approach? With the official Mollie for WooCommerce plugin, there were also users who didn't like the fact that the iDEAL issuer field had simply been removed. For example, because the gateway text contained a reference to the iDEAL bank selection field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants