Skip to content

Commit 596ac75

Browse files
committed
Fix stackdelete problem
Signed-off-by: Drumil Patel <[email protected]>
1 parent 2f10379 commit 596ac75

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

go.mod

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,5 @@ require (
2626
k8s.io/apimachinery v0.18.4
2727
k8s.io/client-go v0.18.4
2828
sigs.k8s.io/aws-iam-authenticator v0.5.1
29-
<<<<<<< HEAD
3029
sigs.k8s.io/kind v0.8.1
31-
=======
32-
>>>>>>> Add aws iam based authentication
3330
)

pkg/provider/eks/eks.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,7 @@ func (c *EKS) createStack(clusterName string) ([]string, error) {
252252
Value: aws.String("shared"),
253253
},
254254
},
255+
DisableRollback: aws.Bool(true),
255256
}
256257

257258
log.Printf("Stack create request: name:'%s'", *req.StackName)
@@ -327,11 +328,12 @@ func (c *EKS) stackDeleted(name string) (bool, error) {
327328
}
328329
stackRes, err := c.clientCF.DescribeStacks(req)
329330

330-
if err.(awserr.Error).Code() == "ValidationError" {
331-
return true, nil
332-
}
333-
334331
if err != nil {
332+
333+
if err.(awserr.Error).Code() == "ValidationError" {
334+
return true, nil
335+
}
336+
335337
return false, fmt.Errorf("Couldn't get stack status: %v", err)
336338
}
337339

0 commit comments

Comments
 (0)