1. Removed secretes , env variables from 3b_prometheus-test_deployment.yaml.

2. Added a section for secretes in kind.md file
Signed-off-by: Kushal Shukla <[email protected]>

Author: kushalShukla-web

prombench/docs/kind.md

@@ -114,7 +114,20 @@ If used with the GitHub integration:
    export PR_NUMBER=<PR to benchmark against the selected $RELEASE>
    ```
 
-2. Deploy the Kubernetes objects:
+2. Before applying benchmarking objects , You have to choices to make:  
+- **Option 1: Download data from object storage**
+
+   To download data from object storage, create a Kubernetes secret with exact named `bucket-config` and file name ```object-config.yml```  with the necessary credentials as per your object storage. This secret enables access to the stored data.
+> Note: Make sure this secret applied before ```3b_prometheus-test_deployment.yaml```
+- **Option 2: Skip downloading data**
+
+   If you don’t need to download data, edit the `3b_prometheus-test_deployment.yaml` file:
+
+   - Remove the `bucket-config` volume section from.
+   - Remove the `volumeMount` section name `bucket-config` from `data-downloader`.
+> Note: You have to remove these two sections from both prometheus-test-pr-{{ .PR_NUMBER }} and prometheus-test-{{ normalise .RELEASE }} deployments.
+
+3. Deploy the Kubernetes objects:
    > **_Note:_** If you encounter a `too many files open` error caused by promtail, increase the default value of `/proc/sys/fs/inotify/max_user_instances` from 128 to 512:
    > ```bash
    > sudo sysctl fs.inotify.max_user_instances=512

prombench/manifests/prombench/benchmark/2a_prometheus-secret.yaml

@@ -52,18 +52,11 @@ spec:
           mountPath: /config     
       - name: data-downloader
         image: kushalshukla/writer
-        imagePullPolicy: Always
-        env:
-        - name: ACCESS_KEY
-          value: "{{ .ACCESS_KEY }}"
-        - name: SECRET_KEY
-          value: "{{ .SECRET_KEY }}"  
-        - name: BUCKET_KEY
-          value: "{{ .BUCKET_KEY }}"                
+        imagePullPolicy: Always                
         volumeMounts:
         - name: instance-ssd
           mountPath: /data
-        - name: s3-config
+        - name: bucket-config
           mountPath: /config
         - name: key
           mountPath: /key
@@ -107,9 +100,9 @@ spec:
           path: /mnt/disks/ssd0 #gke ssds
       - name: prometheus-executable
         emptyDir: {}
-      - name: s3-config   # Define the Secret volume
+      - name: bucket-config   # Define the Secret volume
         secret:
-          secretName: s3-secret
+          secretName: bucket-secret
       - name: key
         emptyDir: {}                  
       terminationGracePeriodSeconds: 300
@@ -185,18 +178,11 @@ spec:
           mountPath: /config
       - name: data-downloader
         image: kushalshukla/writer
-        imagePullPolicy: Always
-        env:
-        - name: ACCESS_KEY
-          value: "{{ .ACCESS_KEY }}"
-        - name: SECRET_KEY
-          value: "{{ .SECRET_KEY }}"  
-        - name: BUCKET_KEY
-          value: "{{ .BUCKET_KEY }}"                  
+        imagePullPolicy: Always                  
         volumeMounts:
         - name: instance-ssd
           mountPath: /data
-        - name: s3-config
+        - name: bucket-config
           mountPath: /config
         - name: key
           mountPath: /key            
@@ -231,9 +217,9 @@ spec:
       - name: config
         hostPath:
           path: /object-config
-      - name: s3-config   # Define the Secret volume
+      - name: bucket-config   # Define the Secret volume
         secret:
-          secretName: s3-secret
+          secretName: bucket-secret
       - name: key
         emptyDir: {}                              
       terminationGracePeriodSeconds: 300