From 7f003f7cbafd1cce35919803be68d17077ad3b32 Mon Sep 17 00:00:00 2001
From: Doug Hoard <dhoard@users.noreply.github.com>
Date: Fri, 6 Dec 2024 17:15:38 -0500
Subject: [PATCH] Refactored build to publish collector jar to Maven Central
 (#1088)

---
 collector/pom.xml                             | 132 ++++++++++++++++--
 .../integration_tests/pom.xml                 |  25 +++-
 .../jmx_example_application/pom.xml           |  27 +++-
 integration_test_suite/pom.xml                |  41 +++---
 jmx_prometheus_common/pom.xml                 |  30 +++-
 jmx_prometheus_javaagent/pom.xml              |  29 +++-
 jmx_prometheus_standalone/pom.xml             |  29 +++-
 pom.xml                                       |  65 ++++-----
 8 files changed, 278 insertions(+), 100 deletions(-)

diff --git a/collector/pom.xml b/collector/pom.xml
index 54f1cf16..08ed5a7c 100644
--- a/collector/pom.xml
+++ b/collector/pom.xml
@@ -1,18 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
-
-    <parent>
-        <groupId>io.prometheus.jmx</groupId>
-        <artifactId>parent</artifactId>
-        <version>1.1.0-post</version>
-    </parent>
 
+    <modelVersion>4.0.0</modelVersion>
+    <groupId>io.prometheus.jmx</groupId>
     <artifactId>collector</artifactId>
+    <version>1.1.0</version>
+    <packaging>jar</packaging>
     <name>Prometheus JMX Exporter - Collector</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
 
     <licenses>
@@ -23,11 +18,60 @@
         </license>
     </licenses>
 
+    <developers>
+        <developer>
+            <name>Doug Hoard</name>
+            <email>doug.hoard@gmail.com</email>
+        </developer>
+        <developer>
+            <name>Fabian Stäber</name>
+            <email>fabian@fstab.de</email>
+        </developer>
+    </developers>
+
+    <scm>
+        <connection>scm:git:git@github.com:prometheus/jmx_exporter.git</connection>
+        <developerConnection>scm:git:git@github.com:prometheus/jmx_exporter.git</developerConnection>
+        <url>git@github.com:prometheus/jmx_exporter.git</url>
+        <tag>HEAD</tag>
+    </scm>
+
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+        <prometheus.metrics.version>1.3.4</prometheus.metrics.version>
     </properties>
 
+    <dependencyManagement>
+        <dependencies>
+            <dependency>
+                <groupId>io.prometheus</groupId>
+                <artifactId>prometheus-metrics-core</artifactId>
+                <version>${prometheus.metrics.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.prometheus</groupId>
+                <artifactId>prometheus-metrics-model</artifactId>
+                <version>${prometheus.metrics.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.prometheus</groupId>
+                <artifactId>prometheus-metrics-instrumentation-jvm</artifactId>
+                <version>${prometheus.metrics.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.prometheus</groupId>
+                <artifactId>prometheus-metrics-exporter-httpserver</artifactId>
+                <version>${prometheus.metrics.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.prometheus</groupId>
+                <artifactId>prometheus-metrics-exporter-opentelemetry</artifactId>
+                <version>${prometheus.metrics.version}</version>
+            </dependency>
+        </dependencies>
+    </dependencyManagement>
+
     <dependencies>
         <dependency>
             <groupId>io.prometheus</groupId>
@@ -81,6 +125,7 @@
             <plugin>
                 <groupId>com.diffplug.spotless</groupId>
                 <artifactId>spotless-maven-plugin</artifactId>
+                <version>2.43.0</version>
                 <configuration>
                     <java>
                         <googleJavaFormat>
@@ -131,4 +176,71 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-javadoc-plugin</artifactId>
+                        <version>3.11.1</version>
+                        <executions>
+                            <execution>
+                                <id>attach-javadocs</id>
+                                <goals>
+                                    <goal>jar</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                    </plugin>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-gpg-plugin</artifactId>
+                        <version>3.2.7</version>
+                        <executions>
+                            <execution>
+                                <id>sign-artifacts</id>
+                                <phase>verify</phase>
+                                <goals>
+                                    <goal>sign</goal>
+                                </goals>
+                                <configuration>
+                                    <gpgArguments>
+                                        <arg>--pinentry-mode</arg>
+                                        <arg>loopback</arg>
+                                    </gpgArguments>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-source-plugin</artifactId>
+                        <version>3.3.1</version>
+                        <executions>
+                            <execution>
+                                <id>attach-sources</id>
+                                <goals>
+                                    <goal>jar-no-fork</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                    </plugin>
+                    <plugin>
+                        <groupId>org.sonatype.central</groupId>
+                        <artifactId>central-publishing-maven-plugin</artifactId>
+                        <version>0.6.0</version>
+                        <extensions>true</extensions>
+                        <configuration>
+                            <publishingServerId>central</publishingServerId>
+                            <autoPublish>false</autoPublish>
+                            <waitUntil>published</waitUntil>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>
diff --git a/integration_test_suite/integration_tests/pom.xml b/integration_test_suite/integration_tests/pom.xml
index 4d04b824..d9050810 100644
--- a/integration_test_suite/integration_tests/pom.xml
+++ b/integration_test_suite/integration_tests/pom.xml
@@ -1,18 +1,17 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
         <groupId>io.prometheus.jmx</groupId>
         <artifactId>integration_test_suite</artifactId>
-        <version>1.1.0-post</version>
+        <version>1.1.0</version>
     </parent>
 
     <artifactId>integration_tests</artifactId>
     <name>Prometheus JMX Exporter - Integration Tests</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
 
     <licenses>
@@ -186,4 +185,22 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-deploy-plugin</artifactId>
+                        <version>3.1.3</version>
+                        <configuration>
+                            <skip>true</skip>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>
diff --git a/integration_test_suite/jmx_example_application/pom.xml b/integration_test_suite/jmx_example_application/pom.xml
index e585042e..605e8e2a 100644
--- a/integration_test_suite/jmx_example_application/pom.xml
+++ b/integration_test_suite/jmx_example_application/pom.xml
@@ -1,18 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
 
+    <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>io.prometheus.jmx</groupId>
         <artifactId>integration_test_suite</artifactId>
-        <version>1.1.0-post</version>
+        <version>1.1.0</version>
     </parent>
-
     <artifactId>jmx_example_application</artifactId>
     <name>Prometheus JMX Exporter - JMX Example Application</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
 
     <licenses>
@@ -141,4 +138,22 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-deploy-plugin</artifactId>
+                        <version>3.1.3</version>
+                        <configuration>
+                            <skip>true</skip>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>
diff --git a/integration_test_suite/pom.xml b/integration_test_suite/pom.xml
index 04d23d3c..475a2bd0 100644
--- a/integration_test_suite/pom.xml
+++ b/integration_test_suite/pom.xml
@@ -1,16 +1,12 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
 
+    <modelVersion>4.0.0</modelVersion>
     <groupId>io.prometheus.jmx</groupId>
     <artifactId>integration_test_suite</artifactId>
-    <version>1.1.0-post</version>
+    <version>1.1.0</version>
     <name>Prometheus JMX Exporter - Integration Test Suite</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
-
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
-
     <packaging>pom</packaging>
 
     <licenses>
@@ -23,6 +19,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <prometheus.metrics.version>1.3.4</prometheus.metrics.version>
     </properties>
 
@@ -34,10 +31,6 @@
     <build>
         <pluginManagement>
             <plugins>
-                <plugin>
-                    <artifactId>maven-deploy-plugin</artifactId>
-                    <version>3.1.3</version>
-                </plugin>
                 <plugin>
                     <artifactId>maven-shade-plugin</artifactId>
                     <version>3.6.0</version>
@@ -63,16 +56,10 @@
                     <compilerArgument>-Xbootclasspath/a:${env.JAVA_HOME}/lib/</compilerArgument>
                 </configuration>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-deploy-plugin</artifactId>
-                <configuration>
-                    <skip>true</skip>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>com.diffplug.spotless</groupId>
                 <artifactId>spotless-maven-plugin</artifactId>
+                <version>2.43.0</version>
                 <configuration>
                     <java>
                         <googleJavaFormat>
@@ -114,4 +101,22 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-deploy-plugin</artifactId>
+                        <version>3.1.3</version>
+                        <configuration>
+                            <skip>true</skip>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>
diff --git a/jmx_prometheus_common/pom.xml b/jmx_prometheus_common/pom.xml
index 13a23de9..9fe71ec4 100644
--- a/jmx_prometheus_common/pom.xml
+++ b/jmx_prometheus_common/pom.xml
@@ -1,18 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-    <modelVersion>4.0.0</modelVersion>
 
+    <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>io.prometheus.jmx</groupId>
-        <artifactId>parent</artifactId>
-        <version>1.1.0-post</version>
+        <artifactId>jmx_exporter</artifactId>
+        <version>1.1.0</version>
     </parent>
-
     <artifactId>jmx_prometheus_common</artifactId>
     <name>Prometheus JMX Exporter - Common</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
 
     <licenses>
@@ -78,6 +75,7 @@
             <plugin>
                 <groupId>com.diffplug.spotless</groupId>
                 <artifactId>spotless-maven-plugin</artifactId>
+                <version>2.43.0</version>
                 <configuration>
                     <java>
                         <googleJavaFormat>
@@ -119,4 +117,22 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-deploy-plugin</artifactId>
+                        <version>3.1.3</version>
+                        <configuration>
+                            <skip>true</skip>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>
diff --git a/jmx_prometheus_javaagent/pom.xml b/jmx_prometheus_javaagent/pom.xml
index 73266d74..f21fa76b 100644
--- a/jmx_prometheus_javaagent/pom.xml
+++ b/jmx_prometheus_javaagent/pom.xml
@@ -1,18 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
 
+    <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>io.prometheus.jmx</groupId>
-        <artifactId>parent</artifactId>
-        <version>1.1.0-post</version>
+        <artifactId>jmx_exporter</artifactId>
+        <version>1.1.0</version>
     </parent>
-
     <artifactId>jmx_prometheus_javaagent</artifactId>
     <name>Prometheus JMX Exporter - Java Agent</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
 
     <licenses>
@@ -195,4 +192,22 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-deploy-plugin</artifactId>
+                        <version>3.1.3</version>
+                        <configuration>
+                            <skip>true</skip>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>
diff --git a/jmx_prometheus_standalone/pom.xml b/jmx_prometheus_standalone/pom.xml
index 88a62a78..aa552b21 100644
--- a/jmx_prometheus_standalone/pom.xml
+++ b/jmx_prometheus_standalone/pom.xml
@@ -1,18 +1,15 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
 
+    <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>io.prometheus.jmx</groupId>
-        <artifactId>parent</artifactId>
-        <version>1.1.0-post</version>
+        <artifactId>jmx_exporter</artifactId>
+        <version>1.1.0</version>
     </parent>
-
     <artifactId>jmx_prometheus_standalone</artifactId>
     <name>Prometheus JMX Exporter - Standalone Server</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
 
     <licenses>
@@ -219,4 +216,22 @@
         </plugins>
     </build>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-deploy-plugin</artifactId>
+                        <version>3.1.3</version>
+                        <configuration>
+                            <skip>true</skip>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>
diff --git a/pom.xml b/pom.xml
index e54cc276..ce8cd02f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1,17 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
 
+    <modelVersion>4.0.0</modelVersion>
     <groupId>io.prometheus.jmx</groupId>
-    <artifactId>parent</artifactId>
-    <version>1.1.0-post</version>
-
+    <artifactId>jmx_exporter</artifactId>
+    <version>1.1.0</version>
     <name>Prometheus JMX Exporter</name>
-    <description>
-        See https://github.com/prometheus/jmx_exporter/blob/master/README.md
-    </description>
+    <description>See https://github.com/prometheus/jmx_exporter/blob/main/README.md</description>
     <url>https://github.com/prometheus/jmx_exporter</url>
-
     <packaging>pom</packaging>
 
     <licenses>
@@ -24,27 +20,10 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <prometheus.metrics.version>1.3.4</prometheus.metrics.version>
     </properties>
 
-    <scm>
-        <connection>scm:git:git@github.com:prometheus/jmx_exporter.git</connection>
-        <developerConnection>scm:git:git@github.com:prometheus/jmx_exporter.git</developerConnection>
-        <url>git@github.com:prometheus/jmx_exporter.git</url>
-        <tag>HEAD</tag>
-    </scm>
-
-    <developers>
-        <developer>
-            <name>Fabian Stäber</name>
-            <email>fabian@fstab.de</email>
-        </developer>
-        <developer>
-            <name>Doug Hoard</name>
-            <email>doug.hoard@gmail.com</email>
-        </developer>
-    </developers>
-
     <modules>
         <module>collector</module>
         <module>jmx_prometheus_common</module>
@@ -53,17 +32,6 @@
         <module>integration_test_suite</module>
     </modules>
 
-    <distributionManagement>
-        <snapshotRepository>
-            <id>ossrh</id>
-            <url>https://oss.sonatype.org/content/repositories/snapshots</url>
-        </snapshotRepository>
-        <repository>
-            <id>ossrh</id>
-            <url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url>
-        </repository>
-    </distributionManagement>
-
     <dependencyManagement>
         <dependencies>
             <dependency>
@@ -101,10 +69,6 @@
                     <artifactId>maven-install-plugin</artifactId>
                     <version>3.1.3</version>
                 </plugin>
-                <plugin>
-                    <artifactId>maven-deploy-plugin</artifactId>
-                    <version>3.1.3</version>
-                </plugin>
                 <plugin>
                     <artifactId>maven-resources-plugin</artifactId>
                     <version>3.3.1</version>
@@ -250,6 +214,7 @@
             <plugin>
                 <groupId>com.diffplug.spotless</groupId>
                 <artifactId>spotless-maven-plugin</artifactId>
+                <version>2.43.0</version>
                 <configuration>
                     <java>
                         <googleJavaFormat>
@@ -298,4 +263,22 @@
         </plugins>
     </reporting>
 
+    <profiles>
+        <profile>
+            <id>release</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-deploy-plugin</artifactId>
+                        <version>3.1.3</version>
+                        <configuration>
+                            <skip>true</skip>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+    </profiles>
+
 </project>