Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the entrypoint from the interface #3

Open
grobie opened this issue Apr 9, 2016 · 2 comments
Open

Remove the entrypoint from the interface #3

grobie opened this issue Apr 9, 2016 · 2 comments

Comments

@grobie
Copy link
Member

grobie commented Apr 9, 2016

I'd suggest to not set an entrypoint in the Dockerfile but leave that to the caller. The builder.sh script should be in the PATH so that one can run the docker container with docker run --rm prom/golang-builder:1.5.3-main builder.sh [options]. This will also allow to provide more than one command later, for diagnosis for example.

@sdurrheimer
Copy link
Contributor

We could yes, but it is already possible to execute another command by using the --entrypoint option.

@grobie
Copy link
Member Author

grobie commented Apr 9, 2016

Yes, that's what I'm using right now. I've found making the entrypoint always explicit helps the future reader of commands and is also more consistent than to sometimes set the --entrypoint and to sometimes rely on a default not immediately apparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants