Skip to content

Commit 1747637

Browse files
committed
Make the additions simpler
`url` is now constant, no extra work for string replacing anymore. Signed-off-by: Alper Polat <[email protected]>
1 parent 315cab7 commit 1747637

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

cmd/builder-bumper/main.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func fetchJSON(url string) ([]byte, error) {
127127

128128
func availableVersions() []goVersion {
129129

130-
url := "https://go.dev/dl/?mode=json"
130+
const url = "https://go.dev/dl/?mode=json"
131131

132132
jsonData, err := fetchJSON(url)
133133
if err != nil {
@@ -140,9 +140,8 @@ func availableVersions() []goVersion {
140140
fmt.Println("Error parsing JSON:", err)
141141
}
142142
for i := range availableVersionsJSON {
143-
// replace "go" from a string like "go1.22.0"
144-
availableVersionsJSON[i].Version = strings.Replace(availableVersionsJSON[i].Version, "go", "", 1)
145-
newGoVersion := newGoVersion(availableVersionsJSON[i].Version)
143+
// remove "go" from a string like "go1.22.0"
144+
newGoVersion := newGoVersion(strings.TrimLeft("go", availableVersionsJSON[i].Version))
146145
availableVersions = append(availableVersions, *newGoVersion)
147146
}
148147
return availableVersions

0 commit comments

Comments
 (0)