Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Shield DDoSDetected metric splitting to snakecase on change from upper to lowercase letter #769

Open
AronNaylor opened this issue Nov 11, 2024 · 0 comments

Comments

@AronNaylor
Copy link

When splitting the AWS Shield Advanced DDoSDetected CloudWatch metric, it is incorrectly being parsed as follows due to the linked method:

region: us-east-1
metrics:
- aws_dimensions:
  aws_metric_name: DDoSDetected
  aws_namespace: AWS/DDoSProtection
  aws_statistics:
  - Sum

Becomes:

aws_ddosprotection_ddo_sdetected_sum

This occurs only when a lowercase letter appears in the middle of a word within a metric name which contains multiple words (see example above), but not the namespace (see code refs below).

return str.replaceAll("([a-z0-9])([A-Z])", "$1_$2").toLowerCase();

safeName(rule.awsNamespace.toLowerCase() + "_" + toSnakeCase(rule.awsMetricName));

@AronNaylor AronNaylor changed the title AWS Shield DDoSDetected metric splitting to camelcase on change from upper to lowercase letter AWS Shield DDoSDetected metric splitting to snakecase on change from upper to lowercase letter Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant