Add sanity check for label value (#1012)

Signed-off-by: Pengfei Zhang <[email protected]>
prometheus · Mar 9, 2024 · 4535ce0 · 4535ce0
1 parent 7a80f00
commit 4535ce0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/prometheus_client/metrics.py b/prometheus_client/metrics.py
@@ -705,6 +705,8 @@ def info(self, val: Dict[str, str]) -> None:
         if self._labelname_set.intersection(val.keys()):
             raise ValueError('Overlapping labels for Info metric, metric: {} child: {}'.format(
                 self._labelnames, val))
+        if any(i is None for i in val.values()):
+            raise ValueError('Label value cannot be None')
         with self._lock:
             self._value = dict(val)
 

diff --git a/tests/test_core.py b/tests/test_core.py
@@ -534,6 +534,7 @@ def test_info(self):
 
     def test_labels(self):
         self.assertRaises(ValueError, self.labels.labels('a').info, {'l': ''})
+        self.assertRaises(ValueError, self.labels.labels('a').info, {'il': None})
 
         self.labels.labels('a').info({'foo': 'bar'})
         self.assertEqual(1, self.registry.get_sample_value('il_info', {'l': 'a', 'foo': 'bar'}))