-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UTF8 Support #916
Comments
I'll start by implementing UTF-8 support in the Java client library |
@fedetorres93 thanks for volunteering, I really appreciate that! Is there any general guidance yet on how to implement it, for example how to convert UTF-8 names to Prometheus names for older Prometheus servers, and how to deal with potential name collisions when registering metrics? It would be good to define the behavior first before implementing it. Ideally the behavior would be consistent across client libraries in all programming languages. |
@fstab You can find the proposals @ywwg worked on here and here. I'm working on adding UTF-8 metric and label name validations and support for parsing and formatting the UTF-8 text format, but there's still some discussion going on about the content negotiation implementation on writes and also regarding how the reads will be handled |
Thanks @fedetorres93! There is already support for dots in metric and label names in Currently dots are only exposed in OpenTelemetry format. In Prometheus text format, OpenMetrics text format, and OpenMetrics protobuf format dots are replaced with underscores. I assume for UTF-8 characters in Prometheus format we will define a new OpenMetrics version, right? I think the following two considerations make sense:
What do you think? If you feel we should have a small "client library support for UTF-8" proposal with the points above I'm happy to write one. |
Thanks for the info @fstab! I don't think another proposal is necessary, but I appreciate the points you mentioned and will take them into account for the implementation. |
Part of prometheus/prometheus#13095, all client libraries will need to support the new scraping, query, and content negotiation formats.
The text was updated successfully, but these errors were encountered: