Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM 2.0: Consider not removing the _total suffix for counter metric family names #281

Closed
dashpole opened this issue Dec 2, 2024 · 1 comment

Comments

@dashpole
Copy link

dashpole commented Dec 2, 2024

As described in prometheus/client_golang#829 (comment), removing the suffix from the metric family name can cause name collisions between metric families. This is one of the reasons why Kubernetes was not able to adopt OpenMetrics 1.0: kubernetes/kubernetes#120027 (comment).

@dashpole
Copy link
Author

Closing in favor of #282. I don't remember why I opened both.

@github-project-automation github-project-automation bot moved this from Todo to Done in Open Metrics 2.0 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant