Attempt to fix issues with disappearing snapshots when using nested ecs

[rgurley]

Only a partial fix, but better than no fix at all I suppose.

[darkv]

Hi Ramsey, are you already using this in production? Shall we commit this?

[rgurley]

Yeah, we used that for months here without issues. It didn't solve our problem, but it didn't hurt either.

On Jan 25, 2013, at 8:22 AM, Johann Werner wrote:

Hi Ramsey, are you already using this in production? Shall we commit this?

—
Reply to this email directly or view it on GitHub.

[darkv]

Does "didn't solve our problem" mean it didn't completely solve it or it didn't improve the situation at all?

[rgurley]

The unit test demonstrates a way to cause the disappearing snapshot. The update fixes the problem in the unit test, but there are other ways that snapshots disappear. Our problem is one of those other ways, but I've not found a way to reproduce the issue we are having.

On Jan 25, 2013, at 2:27 PM, Johann Werner wrote:

Does "didn't solve our problem" mean it didn't completely solve it or it didn't improve the situation at all?

—
Reply to this email directly or view it on GitHub.

[darkv]

In that case we should merge this if you have no objections.

[pascalrobert]

It was merged in master instead of integration...

[darkv]

argh, didn't notice

[rgurley]

D'oh. Sorry. I thought I did make the pull request against integration.