Minor refactoring of ERXStringUtilities.distance(). #312 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is really just a cut and paste of the implementation of 'double distance(String, String)' into 'int levenshteinDistance(String, String)', and a replacement of the body of the former method with a call to the latter. (We don't even need a cast to go from int to double.) We also take the opportunity to deprecate distance(), and mark it for potential future removal. Note that distance() still passes all the tests in ERXStringUtilitiesTest.testDistance().
darkv
added a commit
that referenced
this pull request
Nov 8, 2012
Minor refactoring of ERXStringUtilities.distance(). #312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #312, these commits add a new method,
levenshteinDistance()(which returns anint), implements that method with the body ofdistance(), and then changes the implementation ofdistance()to use the new method. Further, we deprecatedistance()(because it unnecessarily returns adoubleinstead of anint), fix the Javadocs that originally documenteddistance(), and updateERXStringUtilitiesTestto show that none of this makes any functional difference.