Skip to content

Problem with E00001 in get_error_message in error.py under fluent.syntax package #204

@createduser

Description

@createduser

This is a very small problem. When I was looking at the source files in the fluent.syntax package, I found that in the get_error_message function in errors.py, the other error codes were all in the same format as E0003 with only four digits. Only E00001 was five digits. Since I am trying to develop a Fluent parser for the JVM in Kotlin, I need to know if this is intentional. This paragraph is originally in Chinese. I used Google Translate, so there may be some inaccuracies. The original Chinese text is below.

这是一个很小的问题。我在查看fluent.syntax包下源文件时发现errors.py中的get_error_message函数中,其它错误代码都是类似于E0003只有四位数字这样格式的错误代码。唯独只有E00001是五位数字。由于我在试着用Kotlin开发适用于JVM的Fluent解析器,我需要了解这是不是有意而为之。这段话原话是中文,我使用了谷歌翻译,有可能有不正确的地方。

Activity

eemeli

eemeli commented on Jul 25, 2024

@eemeli
Member

That looks like a typo originally made here for fluent.js, and then ported to this implementation.

Given that there is no code path that that produces a Generic Error, a PR fixing the code for it would be welcome both here and in projectfluent/fluent.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @eemeli@createduser

        Issue actions

          Problem with E00001 in get_error_message in error.py under fluent.syntax package · Issue #204 · projectfluent/python-fluent