Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields for geogname & places are redundant and should be consolidated #1431

Open
seanaery opened this issue Dec 4, 2023 · 0 comments
Open
Assignees

Comments

@seanaery
Copy link
Contributor

seanaery commented Dec 4, 2023

ArcLight is currently capturing and representing place metadata in a confusing way, using more fields than necessary. I believe we should just use places_ssim consistently and stop using both geogname_ssim & geogname_ssm. Current references to those fields as follows...

ead2_config.rb (collection-level):

to_field 'geogname_ssm', extract_xpath('/ead/archdesc/controlaccess/geogname')
to_field 'geogname_ssim', extract_xpath('/ead/archdesc/controlaccess/geogname')
...
to_field 'places_ssim', extract_xpath('/ead/archdesc/controlaccess/geogname')

ead2_component_config.rb:

to_field 'geogname_ssim', extract_xpath('./controlaccess/geogname')
to_field 'geogname_ssm', extract_xpath('./controlaccess/geogname')
to_field 'places_ssim', extract_xpath('./controlaccess/geogname')

It's the same data. Whatever's in controlaccess/geogname is what becomes Places. But throughout in the app, there are inconsistent references to the Places field that makes it unnecessarily complicated and error-prone.

solrconfig.xml

  • uses geogname_ssim for <str name="facet.field">geogname_ssim</str>
  • uses geogname_ssm and places_ssim in the <str name="fl"> section
  • uses place_teim for qf, pf, qf_place, pf_place

schema.xml

  • uses places_ssim for <copyField source="places_ssim" dest="place_teim"/>, <copyField source="places_ssim" dest="text" />, and
  • does not use geogname_*

catalog_controller.rb

  • uses geogname_ssim for config.add_facet_field 'place', field: 'geogname_ssim', limit: 10
  • uses places_ssim for config.add_indexed_terms_field 'places', field: 'places_ssim' and config.add_component_indexed_terms_field 'places', field: 'places_ssim'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants