Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

cleanup and consolidate roles #149

Open
miabbott opened this issue May 10, 2017 · 2 comments
Open

cleanup and consolidate roles #149

miabbott opened this issue May 10, 2017 · 2 comments

Comments

@miabbott
Copy link
Collaborator

miabbott commented May 10, 2017

I was stepping (via --step) through the improved-sanity-tests and examining the test itself by hand and realized that we have more than a few instances of duplication in our roles directory.

We should attempt to identify roles that can be combined and made more flexible via passed in parameters.

Things that jump right out:

  • docker_build_httpd & docker_build_tag_push
  • docker_pull_base_image & docker_pull_run_remove
  • docker_rm_httpd_conainer could be generalized
  • maybe some of the verify missing/present roles
@miabbott miabbott changed the title let cleanup and consolidate roles May 10, 2017
@miabbott
Copy link
Collaborator Author

As part of this work, we should try to structure the roles directory using sub-dirs that correspond to major pieces of functionality. For example:

roles/
├── atomic
│   ├── containers
│   ├── images
│   ├── install
│   ├── run
│   └── tasks
├── docker
│   ├── build
│   ├── rm
│   ├── rmi
│   ├── run
│   └── tasks
├── ostree
│   ├── admin
│   ├── log
│   ├── pull
│   ├── remote
│   └── tasks
└── rpm-ostree
    ├── compose
    ├── deploy
    ├── install
    ├── tasks
    └── upgrade

There could be even more sub-dirs under each one of those, too.

@miabbott
Copy link
Collaborator Author

miabbott commented Jun 8, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant