Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trip Details Page UI #705

Open
AminullahTajMuhammad opened this issue Aug 25, 2019 · 16 comments
Open

Update Trip Details Page UI #705

AminullahTajMuhammad opened this issue Aug 25, 2019 · 16 comments

Comments

@AminullahTajMuhammad
Copy link
Contributor

AminullahTajMuhammad commented Aug 25, 2019

Update Trip details page to new UI (screenshot attached)

  • Make sure that page doesn't look out of the place and none of the existing functionality is broken.

Current UI

trip_details_ui

Expected (Updated) UI

image

@Swati4star
Copy link
Member

Do you have suggestions for a new UI? @AminullahTajMuhammad
If yes, please share those too.

@Swati4star Swati4star added the ui label Aug 25, 2019
@AminullahTajMuhammad
Copy link
Contributor Author

@Swati4star Can I working on this UI?

@Swati4star
Copy link
Member

@AminullahTajMuhammad Sure. But, before creating a PR, share the UI mockups here.

@rajput2122
Copy link

Is this issue closed?

@AminullahTajMuhammad
Copy link
Contributor Author

no i am working on it.

@AminullahTajMuhammad
Copy link
Contributor Author

@Swati4star I think the trip detail screen looks like this.

untitled - Trip Detail Screen@2x

@Swati4star
Copy link
Member

Swati4star commented Sep 3, 2019

Some suggestions @AminullahTajMuhammad

  • combine Enter friend name & Add friend in single row
  • Replace "Add friend" button with simply an icon
  • Trip type section can be improved. No need to show such a big "Public". I think this can also be depicted using just icons. globe for public & lock for private trips.

@AminullahTajMuhammad
Copy link
Contributor Author

@Swati4star Here is the updated UX of Trip detail screen. I think the first one is better than this.
Because icons don't define clear meanings of public and private. I think the user will be confused between them.

trip_details_ui_updated

@Swati4star
Copy link
Member

Sure, you can create a PR for this UI 👍
@AminullahTajMuhammad

@prabhakar267 prabhakar267 changed the title Trip Details Screen ui seems not good Update Trip Details Page UI Oct 1, 2019
@Swati4star
Copy link
Member

@AminullahTajMuhammad Updates?

@AminullahTajMuhammad
Copy link
Contributor Author

@Swati4star I am working on it

@aman0408
Copy link
Contributor

aman0408 commented Oct 3, 2019

Can I also give it a try?

AminullahTajMuhammad added a commit to AminullahTajMuhammad/Travel-Mate that referenced this issue Oct 6, 2019
AminullahTajMuhammad added a commit to AminullahTajMuhammad/Travel-Mate that referenced this issue Oct 15, 2019
AminullahTajMuhammad added a commit to AminullahTajMuhammad/Travel-Mate that referenced this issue Oct 16, 2019
AminullahTajMuhammad added a commit to AminullahTajMuhammad/Travel-Mate that referenced this issue Nov 12, 2019
AminullahTajMuhammad added a commit to AminullahTajMuhammad/Travel-Mate that referenced this issue Nov 12, 2019
@eashl003
Copy link

I would love to work on this! May I be assigned to it please?

@Swati4star
Copy link
Member

@eashl003 You can pick either of the issue and start working on it :)

@garima652001
Copy link

Is this issue available to work on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
@Swati4star @prabhakar267 @aman0408 @rajput2122 @AminullahTajMuhammad @garima652001 @eashl003 and others