Skip to content

Incorrect highlighting when selecting an error from the list that's in a different tab #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshgiesbrecht opened this issue May 20, 2025 · 0 comments · May be fixed by #1114
Open

Incorrect highlighting when selecting an error from the list that's in a different tab #1112

joshgiesbrecht opened this issue May 20, 2025 · 0 comments · May be fixed by #1114
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed pde Processing Development Environment

Comments

@joshgiesbrecht
Copy link

Most appropriate sub-area of Processing 4?

PDE

Processing version

4.4.4

Operating system

Windows 10, Debian Linux

Steps to reproduce this

"1.Open a sketch that has multiple tabs.

2.Add some errors and/or warnings in each tab.

3.Click the 'Errors' panel in the bottom of the PDE. Click on one of the errors that is in a tab you don't have open. The highlighting will likely be in the wrong place, and not match up with a line start/end correctly."

snippet

// Paste your code below :)

void setup() {

}

void draw() {

}

Additional context

Found a small one-line fix already which I don't think is too 'hacky'; we just need to activate the selected tab before looking up the relevant character offset for the line number. (It's basing the highlight on the char offset of that line number in the currently visible tab.)

Would you like to work on the issue?

yes plz

@joshgiesbrecht joshgiesbrecht added the bug Something isn't working label May 20, 2025
@Stefterv Stefterv added help wanted Extra attention is needed good first issue Good for newcomers pde Processing Development Environment labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed pde Processing Development Environment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants