Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement broadcast_all() in C/C++ #80

Open
fritzo opened this issue Jan 11, 2018 · 0 comments
Open

Implement broadcast_all() in C/C++ #80

fritzo opened this issue Jan 11, 2018 · 0 comments

Comments

@fritzo
Copy link

fritzo commented Jan 11, 2018

#The distributions.utils.broadcast_all() is used in all distribution constructors to clean up parameters. This is expensive. It would be nice to make this cheaper by reimplementing in C/C++.

Adam suggested using torch._C._infer_size() under the hood but we would need to add more support for scalars.

It would also be good to implement Distribution._validate_log_prob_arg() in C/C++.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant