minor changes + versioning

Author: privefl

DESCRIPTION

@@ -2,8 +2,8 @@ Encoding: UTF-8
 Package: bigsnpr
 Type: Package
 Title: Analysis of Massive SNP Arrays
-Version: 1.12.6
-Date: 2023-10-18
+Version: 1.12.7
+Date: 2024-04-17
 Authors@R: c(
     person("Florian", "Privé", email = "[email protected]", role = c("aut", "cre")),
     person("Michael", "Blum", role = "ths"),

NEWS.md

@@ -1,3 +1,7 @@
+## bigsnpr 1.12.7
+
+- In function `snp_modifyBuild()`, fix a ftp broken link, and add the possibility to use a local chain file specified by the new parameter `local_file`.
+
 ## bigsnpr 1.12.6
 
 - Fix issue with `snp_subset()` when either `$fam` or `$map` are missing.

R/modify-positions.R

@@ -14,6 +14,10 @@
 #' @param to Genome build to convert to. Default is `hg19`.
 #' @param check_reverse Whether to discard positions for which we cannot go back
 #'   to initial values by doing 'from -> to -> from'. Default is `TRUE`.
+#' @param local_chain Local chain file (e.g. `hg18ToHg19.over.chain.gz`) to use
+#'   instead of downloading one from parameters `from` and `to` (the default).
+#'   You can download one such file from e.g.
+#'   \url{https://hgdownload.soe.ucsc.edu/goldenPath/hg18/liftOver/}.
 #'
 #' @references
 #' Hinrichs, Angela S., et al. "The UCSC genome browser database: update 2006."
@@ -25,7 +29,7 @@
 snp_modifyBuild <- function(info_snp, liftOver,
                             from = "hg18", to = "hg19",
                             check_reverse = TRUE,
-                            local.chain = NULL) {
+                            local_chain = NULL) {
 
   if (!all(c("chr", "pos") %in% names(info_snp)))
     stop2("Expecting variables 'chr' and 'pos' in input 'info_snp'.")
@@ -45,16 +49,15 @@ snp_modifyBuild <- function(info_snp, liftOver,
                     BED, col.names = FALSE, sep = " ", scipen = 50)
 
   # Need chain file
-  if (is.null(local.chain) || !file.exists(local.chain)) {
+  if (is.null(local_chain)) {
     url <- paste0("https://hgdownload.soe.ucsc.edu/goldenPath/", from, "/liftOver/",
                   from, "To", tools::toTitleCase(to), ".over.chain.gz")
-    message(paste0("Downloading from ", url))
-    local.chain <- tempfile(fileext = ".over.chain.gz")
-    utils::download.file(url, destfile = local.chain, quiet = TRUE)
+    chain <- tempfile(fileext = ".over.chain.gz")
+    utils::download.file(url, destfile = chain, quiet = TRUE)
   } else {
-    message("Using the local chain file")
+    assert_exist(local_chain)
+    chain <- local_chain
   }
-  chain <- local.chain
 
   # Run liftOver (usage: liftOver oldFile map.chain newFile unMapped)
   lifted <- tempfile(fileext = ".BED")