Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of iterations for breakdown reveal test #1314

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

akoshelev
Copy link
Collaborator

We are having some flakiness with this test: https://github.com/private-attribution/ipa/actions/runs/11018449181/job/30598750956?pr=1307 and I attribute it to having too many iterations (by default it is set to 32). Even running it locally takes a long time and it is not possible to have reliable detection for large routines.

This attempts to fix #1312

We are having some flakiness with this test: https://github.com/private-attribution/ipa/actions/runs/11018449181/job/30598750956?pr=1307 and I attribute it to having too many iterations (by default it is set to 32). Even running it locally takes a long time and it is not possible to have reliable detection for large routines.
@@ -187,7 +187,7 @@ mod tests {
let stream =
BodyStream::from_bytes_stream(stream::once(future::ready(Ok(Bytes::from(data)))));

stream.try_collect::<Vec<_>>().await.unwrap()
stream.try_collect::<Vec<_>>().await.unwrap();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make this change to keep run function definition the same for shuttle and tokio executors

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.45%. Comparing base (1521f8b) to head (b51e62e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...otocol/ipa_prf/boolean_ops/share_conversion_aby.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files         207      207           
  Lines       33451    33455    +4     
=======================================
+ Hits        31260    31267    +7     
+ Misses       2191     2188    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjaminsavage benjaminsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this flaky test!

@benjaminsavage benjaminsavage merged commit 4429326 into private-attribution:main Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakdown reveal aggregation test hangs sometimes
2 participants