Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptive Gate doesn't work with release builds #1301

Open
benjaminsavage opened this issue Sep 21, 2024 · 2 comments
Open

Descriptive Gate doesn't work with release builds #1301

benjaminsavage opened this issue Sep 21, 2024 · 2 comments
Assignees

Comments

@benjaminsavage
Copy link
Collaborator

Command:
cargo run --release --no-default-features --features "multi-threading web-app real-world-infra stall-detection reveal-aggregation" --bin helper -- --identity $IDENTITY --network test_data/network.toml --port $((3000 + (IDENTITY - 1))) --disable-https

Error:

error[E0277]: the trait bound `str: ipa_step::Step` is not satisfied
   --> ipa-core/src/query/executor.rs:217:58
    |
217 |     ipa_step::descriptive::Descriptive::default().narrow("prss")
    |                                                   ------ ^^^^^^ the trait `ipa_step::Step` is not implemented for `str`
    |                                                   |
    |                                                   required by a bound introduced by this call

@andyleiserson
Copy link
Collaborator

This doesn't seem right to me. We want to disable, not enable, string-step in compact gate mode. But perhaps that's not even essential to the issue here, since this is about descriptive gate. I don't think you can specify features for other crates on the command line, so maybe add a new descriptive-gate feature that enables ipa-step/string-step?

@akoshelev
Copy link
Collaborator

yea I agree. This should've been the opposite I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants