Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for attribution #1264

Open
andyleiserson opened this issue Sep 7, 2024 · 0 comments
Open

Improve test coverage for attribution #1264

andyleiserson opened this issue Sep 7, 2024 · 0 comments

Comments

@andyleiserson
Copy link
Collaborator

I am fixing a bug in chunk_rows_by_user where it fails to filter out the last record if the last record is the only record for that user. This caused problems in the logic that manages DZKP batches, but should really be covered by tests in attribution. It could be covered by unit tests for chunk_rows_by_user, but it might also be worth investigating some more general randomized tests or proptests for attribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andyleiserson