Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share a task queue with the Permissions API? #34

Closed
hober opened this issue May 1, 2020 · 2 comments · Fixed by #46
Closed

Share a task queue with the Permissions API? #34

hober opened this issue May 1, 2020 · 2 comments · Fixed by #46
Assignees

Comments

@hober
Copy link
Member

hober commented May 1, 2020

Currently we define our own storage access request queue. Could we use the permission task source instead?

See also #12, #32, and w3c/permissions#206.

@hober hober self-assigned this May 1, 2020
@Brandr0id
Copy link
Member

Seems reasonable to me and aligns with feedback I received from Chromium area owners when implementing the prompt logic. This also has some side effects that the APIs prompt also receives similar protections as other permissions w.r.t. frequent prompts and dismissals/rejections for given origin pairs on top of any explicit flags/logic we define here.

@annevk
Copy link
Collaborator

annevk commented May 5, 2020

I don't think those protections are defined and given that the task source is per event loop you probably need something else to define those kind of details. (No objections to aligning these though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants