Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt changes to navigation to session history rewrite #137

Closed
johannhof opened this issue Nov 9, 2022 · 5 comments
Closed

Adapt changes to navigation to session history rewrite #137

johannhof opened this issue Nov 9, 2022 · 5 comments

Comments

@johannhof
Copy link
Member

We have some new build errors:

LINE ~275: No 'dfn' refs found for 'current entry'.
[=current entry=]

in https://privacycg.github.io/storage-access/#navigation

I suspect that this comes from whatwg/html#6315. I asked @domenic about an easy migration path for this text but it seems like the solution might entail a little more work, so here's two thoughts:

@annevk thoughts?

@annevk
Copy link
Collaborator

annevk commented Nov 9, 2022

If we remove the warning check we'll likely end up introducing quite a few new problems. I would prefer we add an issue marker and remove the broken references (keeping the words, but no longer linking them) if we want a temporary solution.

@johannhof
Copy link
Member Author

Ok that seems like a better solution to me as well, then. I'll comment on the PR.

@johannhof
Copy link
Member Author

I think this was solved with #121 but please correct me if I'm wrong @cfredric

@cfredric
Copy link
Contributor

I think you meant #141, but I agree, #136 fixed the build by unlinking "current entry", and as of #141 the spec no longer references the "current entry" directly, so this seems fixed.

@johannhof
Copy link
Member Author

Oh, yes, I meant #141, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants