Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-English Characters Handled/Displayed Improperly #559

Closed
JoeChampeau opened this issue Jan 12, 2024 · 3 comments · Fixed by #563
Closed

Non-English Characters Handled/Displayed Improperly #559

JoeChampeau opened this issue Jan 12, 2024 · 3 comments · Fixed by #563
Assignees
Labels
bug Something isn't working

Comments

@JoeChampeau
Copy link
Collaborator

Just opening an issue for the bug @dadak-dom encountered. It seems to have something to do with characters with diacritics being displayed as their UTF-8 codes. Currently looking into solutions.

@JoeChampeau JoeChampeau added the bug Something isn't working label Jan 12, 2024
@JoeChampeau JoeChampeau self-assigned this Jan 12, 2024
@JoeChampeau JoeChampeau linked a pull request Jan 19, 2024 that will close this issue
@JoeChampeau
Copy link
Collaborator Author

Issue seems to be fixed right now - what seems to work is decoding non-ASCII characters in URI-encoded URLs and ensuring general regexes for personal keywords allow for non-English characters. Currently, the URL mutation described above only applies when checking for general keywords (because I want to ensure it doesn't, say, impact the ML model), but after further testing I should be able to determine if this is necessary.

@JoeChampeau JoeChampeau linked a pull request Jan 30, 2024 that will close this issue
@JoeChampeau JoeChampeau linked a pull request Jan 30, 2024 that will close this issue
@JoeChampeau
Copy link
Collaborator Author

Will re-review, do some extra testing, and produce a revised assessment on the status of this issue and its associated PR before next meeting.

@SebastianZimmeck
Copy link
Member

@natelevinson10 will work with @JoeChampeau on this issue reviewing the PR (or whatever else you guys determine the appropriate course of action).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants