Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of gen prior to next Rust edition #180

Open
sinui0 opened this issue Sep 5, 2024 · 2 comments · May be fixed by #181
Open

Replace usage of gen prior to next Rust edition #180

sinui0 opened this issue Sep 5, 2024 · 2 comments · May be fixed by #181
Assignees
@heeckhau

Comments

@sinui0
Copy link
Collaborator

sinui0 commented Sep 5, 2024

The keyword gen is being reserved and we use it various places related to a garbled circuit generator. We must replace our usage.
@heeckhau
Copy link
Collaborator

heeckhau commented Sep 5, 2024

You can make Clippy flag this with:

RUSTFLAGS="-D keyword_idents_2024" cargo clippy

@heeckhau heeckhau self-assigned this Sep 5, 2024
heeckhau added a commit that referenced this issue Sep 5, 2024
@heeckhau
fix: Use Cargo Clippy to avoid the gen reserved keyword
5ca9929 
RUSTFLAGS="-D keyword_idents_2024" cargo clippy --fix
fixes #180
@heeckhau
Copy link
Collaborator

heeckhau commented Sep 5, 2024

Cargo clippy has an automatic fix:

RUSTFLAGS="-D keyword_idents_2024" cargo clippy --fix

@heeckhau heeckhau linked a pull request Sep 5, 2024 that will close this issue
Open
@heeckhau heeckhau linked a pull request Sep 5, 2024 that will close this issue
fix: Use Cargo Clippy to avoid the gen reserved keyword #181
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heeckhau heeckhau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use Cargo Clippy to avoid the gen reserved keyword privacy-scaling-explorations/mpz
2 participants
@heeckhau @sinui0