Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize serialization #177

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Organize serialization #177

wants to merge 4 commits into from

Conversation

adria0
Copy link
Member

@adria0 adria0 commented Oct 4, 2024 •
edited
Loading

As described in #176, this PR:

@adria0 adria0 linked an issue Oct 4, 2024 that may be closed by this pull request
Serialization #176
Open
guorong009
guorong009 reviewed Oct 14, 2024
View reviewed changes
Copy link

@guorong009 guorong009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adria0
I think the current update is good.
But, I think we need more updates, if we aim to organize serialization in this PR.

From this comment, I think we can remove the SerdeObject from this repository.
But, it should be done in the basis of implementing the from/to_mont for curve/field.

Please add more implementations if needed.

cc @davidnevadoc

@adria0
Copy link
Member Author

adria0 commented Oct 14, 2024

From this comment, I think we can remove the SerdeObject from this repository. But, it should be done in the basis of implementing the from/to_mont for curve/field.

from/to_mont is already implemented for fields. Do you mean implementing them for curves? I do not see the specific use case the implement from/to_mont for curves (as also, AFAIS does not exist the concept of montgomery for curves, only for fields)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guorong009 guorong009 guorong009 left review comments

@davidnevadoc davidnevadoc Awaiting requested review from davidnevadoc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization Documentation failing for 0.7.0 release
2 participants
@adria0 @guorong009