From f416a1d9b3c01f18996fab279de333f02b56f834 Mon Sep 17 00:00:00 2001 From: guorong009 Date: Wed, 5 Jun 2024 21:03:02 +0800 Subject: [PATCH 1/2] feat: include "shuffles" in "PinnedConstraintSystem::fmt" --- halo2_backend/src/plonk/circuit.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/halo2_backend/src/plonk/circuit.rs b/halo2_backend/src/plonk/circuit.rs index c36bd7b9b4..d9a53edb4e 100644 --- a/halo2_backend/src/plonk/circuit.rs +++ b/halo2_backend/src/plonk/circuit.rs @@ -275,11 +275,9 @@ impl<'a, F: Field> std::fmt::Debug for PinnedConstraintSystem<'a, F> { .field("instance_queries", self.instance_queries) .field("fixed_queries", self.fixed_queries) .field("permutation", self.permutation) - .field("lookups", self.lookups); - if !self.shuffles.is_empty() { - debug_struct.field("shuffles", self.shuffles); - } - debug_struct.field("minimum_degree", self.minimum_degree); + .field("lookups", self.lookups) + .field("shuffles", self.shuffles) + .field("minimum_degree", self.minimum_degree); debug_struct.finish() } } From 2e6a7d652660e2fce0d83e969263cc6148f0b60a Mon Sep 17 00:00:00 2001 From: guorong009 Date: Wed, 5 Jun 2024 21:09:47 +0800 Subject: [PATCH 2/2] chore: fix the "plonk_api" test --- halo2_proofs/tests/plonk_api.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/halo2_proofs/tests/plonk_api.rs b/halo2_proofs/tests/plonk_api.rs index e44484e514..c7512285fe 100644 --- a/halo2_proofs/tests/plonk_api.rs +++ b/halo2_proofs/tests/plonk_api.rs @@ -1112,6 +1112,7 @@ fn plonk_api() { ], }, ], + shuffles: [], minimum_degree: None, }, fixed_commitments: [