From f07d35f47f4fe2e3c7efa90101675a308ef8600c Mon Sep 17 00:00:00 2001 From: ying tong Date: Thu, 24 Aug 2023 02:13:04 +0800 Subject: [PATCH 1/2] Include shuffles in PinnedConstraintSystem fmt --- halo2_proofs/src/plonk/circuit.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/halo2_proofs/src/plonk/circuit.rs b/halo2_proofs/src/plonk/circuit.rs index a5736f28ca..a0b58e22d7 100644 --- a/halo2_proofs/src/plonk/circuit.rs +++ b/halo2_proofs/src/plonk/circuit.rs @@ -1623,6 +1623,7 @@ impl<'a, F: Field> std::fmt::Debug for PinnedConstraintSystem<'a, F> { .field("fixed_queries", self.fixed_queries) .field("permutation", self.permutation) .field("lookups", self.lookups) + .field("shuffles", self.shuffles) .field("constants", self.constants) .field("minimum_degree", self.minimum_degree); debug_struct.finish() From ec12916d715ac95913f80aa1c26f6609d9a46c85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20P=C3=A9rez?= <37264926+CPerezz@users.noreply.github.com> Date: Fri, 10 Nov 2023 08:04:28 +0100 Subject: [PATCH 2/2] Update halo2_proofs/src/plonk/circuit.rs Address @han0110's suggestions Co-authored-by: Han --- halo2_proofs/src/plonk/circuit.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/halo2_proofs/src/plonk/circuit.rs b/halo2_proofs/src/plonk/circuit.rs index a0b58e22d7..b43c6af1fa 100644 --- a/halo2_proofs/src/plonk/circuit.rs +++ b/halo2_proofs/src/plonk/circuit.rs @@ -1622,8 +1622,11 @@ impl<'a, F: Field> std::fmt::Debug for PinnedConstraintSystem<'a, F> { .field("instance_queries", self.instance_queries) .field("fixed_queries", self.fixed_queries) .field("permutation", self.permutation) - .field("lookups", self.lookups) - .field("shuffles", self.shuffles) + .field("lookups", self.lookups); + if !self.shuffles.is_empty() { + debug_struct.field("shuffles", self.shuffles); + } + debug_struct .field("constants", self.constants) .field("minimum_degree", self.minimum_degree); debug_struct.finish()