Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post frontend-backend split] Advice with sealed phase in the frontend #295

Closed
ed255 opened this issue Mar 6, 2024 · 2 comments
Closed

Comments

@ed255
Copy link
Member

ed255 commented Mar 6, 2024

Currently the Advice type used in the frontend comes from the middleware, which exposes the phase as a u8. In order to hide this from the user we need to have copy of the Advice type internal to the frontend with a sealed phase.

Probably this means also brining duplicates for Fixed, Instance, ColumnType and Any into the frontend. After this, the corresponding types in the middleware can be greatly simplified.

Blocked by #290

@duguorong009
Copy link

I believe this issue has already been addressed in #300 .
Hence, I propose that we close this issue as it is resolved or no longer needed.

What do you think? @ed255

@ed255
Copy link
Member Author

ed255 commented Apr 2, 2024

I believe this issue has already been addressed in #300 . Hence, I propose that we close this issue as it is resolved or no longer needed.

What do you think? @ed255

You're totally right! Thanks for checking this, I'll just close the issue :)

@ed255 ed255 closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants