Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on using Flash alerts in dialog components #104

Open
emplums opened this issue May 20, 2020 · 2 comments
Open

Add documentation on using Flash alerts in dialog components #104

emplums opened this issue May 20, 2020 · 2 comments
Assignees

Comments

@emplums
Copy link

emplums commented May 20, 2020

I came across this usage of a Flash alert inside of a details-dialog that felt a bit off:
image

Should we add some documentation about whether or not Flash alerts should be used inside of dialog components? To me it feels a bit redundant since the dialog itself is sort of like an alert but I wasn't 100% sure if this is something we should discourage or not.

@emplums emplums changed the title Add documentation on using Flash alerts in Dialog components Add documentation on using Flash alerts in dialog components May 20, 2020
@simurai
Copy link
Contributor

simurai commented May 21, 2020

Can't find the issue/PR, but there was a case recently where a user could do different actions inside the modal and it needed some sort of waning/error message. So maybe in that case it's fine to use a flash alert? The guide could be:

Only use a flash alert in modals in response to an action taken.

@yaili
Copy link
Member

yaili commented May 21, 2020

This also seems related to danger patterns, maybe we could document a good example of a warning before doing something destructive?

@yaili yaili self-assigned this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants