-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modification request] Add pause button to Logobar #718
Comments
👋 @nsolerieu thanks for opening this request. A few quick questions / clarifications:
It seems like the issue on that page was resolved by turning the marquee animation off. Do you have any examples of this feature having been implemented on a production page? No worries if not, just curious to see it in action. |
@rezrah legend ✨ I'll try to respond to these, but @nsolerieu can fill in if I missed something!
Here are the three production pages where the quick play/pause solution was implemented to work with Logo Suite component with marquee option:
This new play/pause button should present a standard way to play/pause moving content across our pages. Much like Apple does. |
Also here is the play/pause button I believe they want implemented https://githubnext.com/projects/copilot-workspace ✨ |
+1 to all of @stamat points:
|
@jesussandreas I'm just working on this at the moment. Do you have any suggestions of how to implement this on a light-mode LogoSuite? Eg this kind of thing (but better 😅) |
Yes, let me come back to you on this. |
@joshfarrant could it be something like this? |
Thanks @jesussandreas! That's definitely an improvement over my solution ✨ I'll loop in @danielguillan too as, following a chat we had, he spotted a few other things we could do along with just adding the button. |
Problem
Solution
Bake in the component a (subtle) pause button
See @jesussandreas design suggestion here
Urgency
@stamat already fixed this where it was a flagged by a11y as a critical issue - now it's time to update our system. SEV-2 a11y issue: https://github.com/github/accessibility-audits/issues/7881
The text was updated successfully, but these errors were encountered: