Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Select (previously dropdown) component, loading section wrong code example #17626

Closed
1 of 4 tasks
arieffikhrie opened this issue Feb 10, 2025 · 0 comments · Fixed by #17637
Closed
1 of 4 tasks
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@arieffikhrie
Copy link

Describe the bug

The select loading state docs , https://primeng.org/select#loadingstate , showing the Loading... placeholder, but in the code example placeholder="Select a City".

It just bring confusion, since i thought when i put loading to true, it will automatically change the placeholder into Loading text.

Stackblitz are showing the Select a City placeholder and showing the Select a City in the select not Loading...

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

Could not find any contribution guideline for updating documentation

Reproducer

https://stackblitz.com/edit/e3yowdpd?file=src%2Fapp%2Fselect-loading-state-demo.html

Environment

Google Chrome | 132.0.6834.159 (Official Build) (arm64)

Angular version

19.0.1

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/select#loadingstate

Expected behavior

  1. The example code in https://primeng.org/select#loadingstate should be
<p-select [options]="cities" [(ngModel)]="selectedCity" [loading]="true" optionLabel="name" placeholder="Loading..." class="w-full md:w-56" />
@arieffikhrie arieffikhrie added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 10, 2025
@mertsincan mertsincan added this to the 19.0.7 milestone Feb 14, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Feb 14, 2025
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 14, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants