Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate class attribute in example of DataView #17621

Open
4 tasks
Wendelstein7 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #17620
Open
4 tasks

Duplicate class attribute in example of DataView #17621

Wendelstein7 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #17620
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Wendelstein7
Copy link
Contributor

Describe the bug

Two examples in the DataView component have double class attributes, likely a copy-paste error. This issue / bug report exists because it is required for the PR I am creating to fix this documentation error.

This is a line the current documentation:

<div class="col-span-12" *ngFor="let item of items; let first = first" class="col-span-12">

This is my proposed fix:

<div class="col-span-12" *ngFor="let item of items; let first = first">

With kind regards

Pull Request Link

#17620

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

This is not relevant.

Environment

This is not relevant.

Angular version

19.1.5

PrimeNG version

v19

Node version

23.7.0

Browser(s)

No response

Steps to reproduce the behavior

See the DataView docs.

Expected behavior

No double class attributes.

@Wendelstein7 Wendelstein7 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant