New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setDirectionalCondition can be more efficient if a Set is used #85

Open

esromneb opened this issue Oct 26, 2020 · 1 comment

Contributor

esromneb commented Oct 26, 2020

The check for directional conditions uses a loop and would be much more efficient with a Set. Is this something you would accept a PR for?

Owner

prettymuchbryce commented Nov 19, 2020

Ah I see. Yes the directions themselves are a list of directions. We could make them a set. I think it's worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment