Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port refactorings and formatting from pokered/pokegold/pokecrystal #69

Open
8 of 12 tasks
Rangi42 opened this issue Aug 9, 2020 · 1 comment
Open
8 of 12 tasks

Comments

@Rangi42
Copy link
Member

Rangi42 commented Aug 9, 2020

  • Sync labels and constants with Gen 1 or 2 as appropriate
  • Newlines at end of .asm and .inc files
  • Capitalize BANK, HIGH, LOW, DEF
  • Colons after labels
  • Remove trailing whitespace
  • Indent with single tabs, not spaces
  • Remove address comments
  • Remove enum, use improved const
  • New connection macro
  • Use the current constants, data, and engine, and macros subdirectories
  • Use farcall and callfar, not callab and callba
  • Updated audio constants, labels, and macro names (see Update audio macros and arguments pokecrystal#650)
  • More
@Rangi42 Rangi42 changed the title Port refactorings from pokered/pokegold/pokecrystal Port refactorings and formatting from pokered/pokegold/pokecrystal Aug 9, 2020
@Rangi42
Copy link
Member Author

Rangi42 commented Aug 9, 2020

Some chunks of code, like VBlank, clearly evolved from pokered to pokegold, with pokegold-spaceworld being somewhere in the middle. While disassembling spaceworld, it would be a good opportunity to sync pokered and pokegold. For example, AutoBgMapTransfer == UpdateBGMapBuffer, VBlankCopyDouble == Serve1bppRequest, etc. (In general Gen 1 has been getting refactored to be more like Gen 2, which would apply to conventions like "BG" instead of "Bg", but there are also pokered labels worth syncing to pokegold+pokecrystal.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant